OpenE2K/gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

re PR middle-end/15486 (-fdata-sections moves common vars to .bss)

Browse Source 
PR middle-end/15486
	* varasm.c (asm_emit_uninitialised): Return early if
	a custom section is requested.
	(assemble_variable): Revert 2002-03-15 patch.

From-SVN: r92365
This commit is contained in:
Eric Botcazou 2004-12-18 22:49:55 +01:00 committed by Eric Botcazou
parent 36f5ada19a
commit 64270ab056
4 changed files with 38 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gcc/ChangeLog
View File

@ -1,3 +1,10 @@
2004-12-18 Eric Botcazou <ebotcazou@libertysurf.fr>
PR middle-end/15486
* varasm.c (asm_emit_uninitialised): Return early if
a custom section is requested.
(assemble_variable): Revert 2002-03-15 patch.
2004-12-18 Richard Henderson <rth@redhat.com>
* stor-layout.c (layout_decl): Use unshare_expr, not unsave_expr.

4
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,7 @@
2004-12-18 Eric Botcazou <ebotcazou@libertysurf.fr>
* gcc.dg/fdata-sections-1.c: New test.
2004-12-18 Roger Sayle <roger@eyesopen.com>
PR middle-end/18548

9
gcc/testsuite/gcc.dg/fdata-sections-1.c Normal file
View File

@ -0,0 +1,9 @@
/* PR middle-end/15486 */
/* Origin: Jonathan Larmour <jifl-bugzilla@jifvik.org> */
/* { dg-do compile { target *-*-linux* } } */
/* { dg-options "-fdata-sections" } */
int x;
/* { dg-final { scan-assembler "comm" } } */

29
gcc/varasm.c
View File

@ -1442,9 +1442,16 @@ asm_emit_uninitialised (tree decl, const char *name,
destination = asm_dest_common;
}
if (destination != asm_dest_common)
{
resolve_unique_section (decl, 0, flag_data_sections);
/* Custom sections don't belong here. */
if (DECL_SECTION_NAME (decl))
return false;
}
if (destination == asm_dest_bss)
globalize_decl (decl);
resolve_unique_section (decl, 0, flag_data_sections);
if (flag_shared_data)
{
@ -1625,16 +1632,6 @@ assemble_variable (tree decl, int top_level ATTRIBUTE_UNUSED,
if (DECL_PRESERVE_P (decl))
targetm.asm_out.mark_decl_preserved (name);
/* Output any data that we will need to use the address of. */
if (DECL_INITIAL (decl) == error_mark_node)
reloc = contains_pointers_p (TREE_TYPE (decl)) ? 3 : 0;
else if (DECL_INITIAL (decl))
{
reloc = compute_reloc_for_constant (DECL_INITIAL (decl));
output_addressed_constants (DECL_INITIAL (decl));
}
resolve_unique_section (decl, reloc, flag_data_sections);
/* Handle uninitialized definitions. */
/* If the decl has been given an explicit section name, then it
@ -1688,7 +1685,17 @@ assemble_variable (tree decl, int top_level ATTRIBUTE_UNUSED,
if (TREE_PUBLIC (decl) && DECL_NAME (decl))
globalize_decl (decl);
/* Output any data that we will need to use the address of. */
if (DECL_INITIAL (decl) == error_mark_node)
reloc = contains_pointers_p (TREE_TYPE (decl)) ? 3 : 0;
else if (DECL_INITIAL (decl))
{
reloc = compute_reloc_for_constant (DECL_INITIAL (decl));
output_addressed_constants (DECL_INITIAL (decl));
}
/* Switch to the appropriate section. */
resolve_unique_section (decl, reloc, flag_data_sections);
variable_section (decl, reloc);
/* dbxout.c needs to know this. */