OpenE2K/gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

inliner: Copy DECL_BY_REFERENCE in copy_decl_to_var [PR93888]

Browse Source 
In the following testcase we emit wrong debug info for the karg
parameter in the DW_TAG_inlined_subroutine into main.
The problem is that the karg PARM_DECL is DECL_BY_REFERENCE and thus
in the IL has const K & type, but in the source just const K.
When the function is inlined, we create a VAR_DECL for it, but don't
set DECL_BY_REFERENCE, so when emitting DW_AT_location, we treat it like
a const K & typed variable, but it has DW_AT_abstract_origin which has
just the const K type and thus the debugger thinks the variable has
const K type.

Fixed by copying the DECL_BY_REFERENCE flag.  Not doing it in
copy_decl_for_dup_finish, because copy_decl_no_change already copies
that flag through copy_node and in copy_result_decl_to_var it is
undesirable, as we handle DECL_BY_REFERENCE in that case instead
by changing the type.

2020-03-04  Jakub Jelinek  <jakub@redhat.com>

	PR debug/93888
	* tree-inline.c (copy_decl_to_var): Copy DECL_BY_REFERENCE flag.

	* g++.dg/guality/pr93888.C: New test.
This commit is contained in:
Jakub Jelinek 2020-03-04 12:59:04 +01:00
parent 1cdfb80a4e
commit 64ba6d1702
4 changed files with 33 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
gcc/ChangeLog
View File

@ -1,5 +1,8 @@
2020-03-04 Jakub Jelinek <jakub@redhat.com>
PR debug/93888
* tree-inline.c (copy_decl_to_var): Copy DECL_BY_REFERENCE flag.
* tree-ssa-sccvn.c (vn_walk_cb_data::push_partial_def): Add offseti
argument. Change pd argument so that it can be modified. Turn
constant non-CONSTRUCTOR store into non-constant if it is too large.

5
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2020-03-04 Jakub Jelinek <jakub@redhat.com>
PR debug/93888
* g++.dg/guality/pr93888.C: New test.
2020-02-04 Richard Biener <rguenther@suse.de>
PR tree-optimization/93964

24
gcc/testsuite/g++.dg/guality/pr93888.C Normal file
View File

@ -0,0 +1,24 @@
// PR debug/93888
// { dg-do run }
// { dg-options "-g -fvar-tracking -fno-inline" }
// { dg-skip-if "" { *-*-* } { "*" } { "-O0" } }
struct K
{
K () {}
K (K const &rhs) { k[0] = 'C'; }
char k[8] = {'B','B','B','B','B','B','B','B'};
};
__attribute__((always_inline)) inline bool
foo (const K karg)
{
return karg.k[0] != 'C'; // { dg-final { gdb-test 16 "karg.k[0]" "'C'" } }
} // { dg-final { gdb-test 16 "karg.k[1]" "'B'" } }
int
main ()
{
K x;
return foo (x);
}

1
gcc/tree-inline.c
View File

@ -5929,6 +5929,7 @@ copy_decl_to_var (tree decl, copy_body_data *id)
TREE_READONLY (copy) = TREE_READONLY (decl);
TREE_THIS_VOLATILE (copy) = TREE_THIS_VOLATILE (decl);
DECL_GIMPLE_REG_P (copy) = DECL_GIMPLE_REG_P (decl);
DECL_BY_REFERENCE (copy) = DECL_BY_REFERENCE (decl);
return copy_decl_for_dup_finish (id, decl, copy);
}