From 680b9610addf4ff1f004f038e709e16cfab1a947 Mon Sep 17 00:00:00 2001 From: Ed Schonberg Date: Tue, 12 Jan 2021 10:46:26 -0500 Subject: [PATCH] [Ada] Spurious warning on useless assignment with target name gcc/ada/ * sem_ch5.adb (Analyze_Assignment): Do not emit the warning that a previous value of the target object is useless if the right-hand side of the assignment includes target names. --- gcc/ada/sem_ch5.adb | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/gcc/ada/sem_ch5.adb b/gcc/ada/sem_ch5.adb index f03467f5e2d..0aef9321d60 100644 --- a/gcc/ada/sem_ch5.adb +++ b/gcc/ada/sem_ch5.adb @@ -1108,6 +1108,12 @@ package body Sem_Ch5 is -- warnings when an assignment is rewritten as another -- assignment, and gets tied up with itself. + -- We also omit the warning if the RHS includes target names, + -- that is to say the Ada2020 "@" that denotes an instance of + -- the LHS, which indicates that the current value is being + -- used. Note that this implicit reference to the entity on + -- the RHS is not treated as a source reference. + -- There may have been a previous reference to a component of -- the variable, which in general removes the Last_Assignment -- field of the variable to indicate a relevant use of the @@ -1126,6 +1132,7 @@ package body Sem_Ch5 is and then Comes_From_Source (N) and then In_Extended_Main_Source_Unit (Ent) and then not Has_Deferred_Reference (Ent) + and then not Has_Target_Names (N) then Warn_On_Useless_Assignment (Ent, N); end if;