OpenE2K
/
gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[Ada] Add assertions on tampering counts 

gcc/ada/

	* libgnat/a-conhel.adb: Assert that tampering counts remain
	between 0 and 2**31-1.  This makes debugging of
	finalization-related bugs easier.
This commit is contained in:
Bob Duff 2021-05-04 10:13:36 -04:00 committed by Pierre-Marie de Rodat
parent 885efc5e70
commit 68c27b2a70
1 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
gcc/ada/libgnat/a-conhel.adb
View File

@ -27,6 +27,13 @@
package body Ada.Containers.Helpers is
Max_Count : constant := 2**31 - 1;
-- Used in assertions below, to make sure the counts don't wrap around.
-- This can help detect bugs in which Adjust and Finalize calls are
-- improperly generated. An extra Decrement could otherwise cause
-- wraparound from 0 to 2**32-1. The highest count seen so far is
-- around 25, so this should be plenty.
package body Generic_Implementation is
use type SAC.Atomic_Unsigned;
@ -50,6 +57,7 @@ package body Ada.Containers.Helpers is
begin
if T_Check then
SAC.Increment (T_Counts.Busy);
pragma Assert (T_Counts.Busy <= Max_Count);
end if;
end Busy;
@ -112,7 +120,9 @@ package body Ada.Containers.Helpers is
begin
if T_Check then
SAC.Increment (T_Counts.Lock);
pragma Assert (T_Counts.Lock <= Max_Count);
SAC.Increment (T_Counts.Busy);
pragma Assert (T_Counts.Busy <= Max_Count);
end if;
end Lock;
@ -158,6 +168,7 @@ package body Ada.Containers.Helpers is
begin
if T_Check then
SAC.Decrement (T_Counts.Busy);
pragma Assert (T_Counts.Busy <= Max_Count);
end if;
end Unbusy;
@ -169,7 +180,9 @@ package body Ada.Containers.Helpers is
begin
if T_Check then
SAC.Decrement (T_Counts.Lock);
pragma Assert (T_Counts.Lock <= Max_Count);
SAC.Decrement (T_Counts.Busy);
pragma Assert (T_Counts.Busy <= Max_Count);
end if;
end Unlock;