avoid null ptr deref in cselib_record_sets

Jeff Law tells me h8300-elf fails gcc.c-torture/compile/pr49029.c
with -O2 -g -mint32 -mh.  This patch fixes it.

The problem is that strict low part handling in cselib_record_sets
assumes src_elt is not NULL.  That src_elt is taken from a strict low
part set, but it won't always have a src_elt to begin with.  In this
case, it's because src is a volatile MEM; we don't record values for
those.

Although we could fix the problem by testing for a NULL src_elt before
creating the zero extends corresponding to strict low part sets of
formerly const0_rtx REGs, there's no point in recording the additional
set that we won't be able to use anyway.

We could still record that the whole register has a zero-extend of
the value stored in the narrower-mode strict low part of the register,
but is that of any use?  I guess not, but if we find otherwise, we can
change that later.


for  gcc/ChangeLog

	* cselib.c (cselib_record_sets): Skip strict low part sets
	with NULL src_elt.

From-SVN: r266873
This commit is contained in:
Alexandre Oliva 2018-12-06 23:18:19 +00:00 committed by Alexandre Oliva
parent 4cbb7085f0
commit 695be09234
2 changed files with 6 additions and 0 deletions

View File

@ -1,3 +1,8 @@
2018-12-06 Alexandre Oliva <aoliva@redhat.com>
* cselib.c (cselib_record_sets): Skip strict low part sets
with NULL src_elt.
2018-12-06 Paul A. Clarke <pc@us.ibm.com>
PR target/88316

View File

@ -2616,6 +2616,7 @@ cselib_record_sets (rtx_insn *insn)
preserves the upper bits that di:SI=zero_extend(flags:CCNO<=0). */
scalar_int_mode mode;
if (dest != orig
&& sets[i].src_elt
&& cselib_record_sets_hook
&& REG_P (dest)
&& HARD_REGISTER_P (dest)