OpenE2K
/
gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

c: Error on va_arg with function type [PR105149] 

In the PR Joseph said that the C standard for va_arg talks about
pointers to object type and as a function type is not object type,
it is invalid.

The following patch diagnoses it in the FE, instead of ICEing later on
when optimizations are turned on (and with -O0 doing something weird
at runtime).

2022-04-08  Jakub Jelinek  <jakub@redhat.com>

	PR c/105149
	* c-typeck.cc (c_build_va_arg): Reject function types.

	* gcc.dg/pr105149.c: New test.
This commit is contained in:
Jakub Jelinek 2022-04-08 09:16:30 +02:00
parent 5e6597064b
commit 6e27436872
2 changed files with 22 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gcc/c/c-typeck.cc
View File

@ -15896,6 +15896,12 @@ c_build_va_arg (location_t loc1, tree expr, location_t loc2, tree type)
"type %qT", type);
return error_mark_node;
}
else if (TREE_CODE (type) == FUNCTION_TYPE)
{
error_at (loc2, "second argument to %<va_arg%> is a function type %qT",
type);
return error_mark_node;
}
else if (warn_cxx_compat && TREE_CODE (type) == ENUMERAL_TYPE)
warning_at (loc2, OPT_Wc___compat,
"C++ requires promoted type, not enum type, in %<va_arg%>");

16
gcc/testsuite/gcc.dg/pr105149.c Normal file
View File

@ -0,0 +1,16 @@
/* PR c/105149 */
/* { dg-do compile } */
/* { dg-options "-O2" } */
#include <stdarg.h>
void
foo (int s, ...)
{
int e;
va_list ap;
va_start (ap, s);
e = va_arg (ap, int (void)) (); /* { dg-error "second argument to 'va_arg' is a function type" } */
va_end (ap);
}