OpenE2K/gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

S/390: Fix ICE in s390_check_qrst_address ()

Browse Source 
In r265371 (S/390: Make "b" constraint match literal pool references)
the CONSTANT_POOL_ADDRESS_P () check was moved from
s390_loadrelative_operand_p () to s390_check_qrst_address ().  However,
in the original code it was guarded by SYMBOL_REF_P (), which was not
added to the new code.

gcc/ChangeLog:

2018-10-24  Ilya Leoshkevich  <iii@linux.ibm.com>

	* config/s390/s390.c (s390_check_qrst_address): Add the missing
	SYMBOL_REF_P () check.

gcc/testsuite/ChangeLog:

2018-10-24  Ilya Leoshkevich  <iii@linux.ibm.com>

	* gcc.target/s390/20181024-1.c: New test.

From-SVN: r265458
This commit is contained in:
Ilya Leoshkevich 2018-10-24 12:04:53 +00:00 committed by Ilya Leoshkevich
parent be43a8877e
commit 6f7133ec4f
4 changed files with 44 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gcc/ChangeLog
View File

@ -1,3 +1,8 @@
2018-10-24 Ilya Leoshkevich <iii@linux.ibm.com>
* config/s390/s390.c (s390_check_qrst_address): Add the missing
SYMBOL_REF_P () check.
2018-10-24 Richard Biener <rguenther@suse.de>
PR tree-optimization/87105

4
gcc/config/s390/s390.c
View File

@ -3162,7 +3162,9 @@ s390_check_qrst_address (char c, rtx op, bool lit_pool_ok)
/* This check makes sure that no symbolic address (except literal
pool references) are accepted by the R or T constraints. */
if (s390_loadrelative_operand_p (op, &symref, NULL)
&& (!lit_pool_ok || !CONSTANT_POOL_ADDRESS_P (symref)))
&& (!lit_pool_ok
|| !SYMBOL_REF_P (symref)
|| !CONSTANT_POOL_ADDRESS_P (symref)))
return 0;
/* Ensure literal pool references are only accepted if LIT_POOL_OK. */

4
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,7 @@
2018-10-24 Ilya Leoshkevich <iii@linux.ibm.com>
* gcc.target/s390/20181024-1.c: New test.
2018-10-24 Richard Biener <rguenther@suse.de>
PR tree-optimization/87105

32
gcc/testsuite/gcc.target/s390/20181024-1.c Normal file
View File

@ -0,0 +1,32 @@
/* Make sure s390_check_qrst_address () correctly handles UNSPEC rtxs. */
/* { dg-compile } */
/* { dg-options "-march=z196 -O2 -fPIC" } */
int a, b, g, h;
struct
{
int i;
struct
{
int d;
} k[];
} f;
void m(int);
void l()
{
int j;
for (; h;)
{
m((
{
__asm__("" : "=r"(g));
b;
}
));
f.k[j].d = a;
j++;
}
f.i = j;
}