OpenE2K
/
gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix tree-opt/PR106087: ICE with inline-asm with multiple output and assigned only static vars 

The problem here is that when we mark the ssa name that was referenced in the now removed
dead store (to a write only static variable), the inline-asm would also be removed
even though it was defining another ssa name. This fixes the problem by checking
to make sure that the statement was only defining one ssa name.

Committed as approved after a bootstrapped and tested on x86_64 with no regressions.

	PR tree-optimization/106087

gcc/ChangeLog:

	* tree-ssa-dce.cc (simple_dce_from_worklist): Check
	to make sure the statement is only defining one operand.

gcc/testsuite/ChangeLog:

	* gcc.c-torture/compile/inline-asm-1.c: New test.
This commit is contained in:
Andrew Pinski 2022-07-07 22:06:19 +00:00
parent 0fe604a2d9
commit 71e3daa31c
2 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
gcc/testsuite/gcc.c-torture/compile/inline-asm-1.c Normal file
View File

@ -0,0 +1,14 @@
/* PR tree-opt/106087,
simple_dce_from_worklist would delete the
inline-asm when it was still being referenced
by the other ssa name. */
static int t;
int f(void)
{
int tt, tt1;
asm("":"=r"(tt), "=r"(tt1));
t = tt1;
return tt;
}

7
gcc/tree-ssa-dce.cc
View File

@ -2061,6 +2061,13 @@ simple_dce_from_worklist (bitmap worklist)
if (gimple_has_side_effects (t))
continue;
/* The defining statement needs to be defining only this name.
ASM is the only statement that can define more than one
(non-virtual) name. */
if (is_a<gasm *>(t)
&& !single_ssa_def_operand (t, SSA_OP_DEF))
continue;
/* Don't remove statements that are needed for non-call
eh to work. */
if (stmt_unremovable_because_of_non_call_eh_p (cfun, t))