OpenE2K
/
gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Make target_clones resolver fn static if possible. 

PR target/93274
	PR ipa/94271
	* config/i386/i386-features.c (make_resolver_func): Drop
	public flag for resolver.
	* config/rs6000/rs6000.c (make_resolver_func): Add comdat
	group for resolver and drop public flag if possible.
	* multiple_target.c (create_dispatcher_calls): Drop unique_name
	and resolution as we want to enable LTO privatization of the default
	symbol.
	PR target/93274
	PR ipa/94271
	* gcc.target/i386/pr81213-2.c: New test.
	* gcc.target/i386/pr81213.c: Add additional source.
	* gcc.dg/lto/pr94271_0.c: New test.
	* gcc.dg/lto/pr94271_1.c: New test.
This commit is contained in:
Martin Liska 2020-03-25 11:03:39 +01:00
parent 0fb0240a05
commit 724ec02c2c
No known key found for this signature in database
GPG Key ID: 4DC182DC0FA73785
9 changed files with 82 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
gcc/ChangeLog
View File

@ -1,3 +1,15 @@
2020-03-25 Martin Liska <mliska@suse.cz>
PR target/93274
PR ipa/94271
* config/i386/i386-features.c (make_resolver_func): Drop
public flag for resolver.
* config/rs6000/rs6000.c (make_resolver_func): Add comdat
group for resolver and drop public flag if possible.
* multiple_target.c (create_dispatcher_calls): Drop unique_name
and resolution as we want to enable LTO privatization of the default
symbol.
2020-03-25 Martin Liska <mliska@suse.cz>
PR lto/94259

3
gcc/config/i386/i386-features.c
View File

@ -2777,6 +2777,9 @@ make_resolver_func (const tree default_decl,
DECL_COMDAT (decl) = 1;
make_decl_one_only (decl, DECL_ASSEMBLER_NAME (decl));
}
else
TREE_PUBLIC (ifunc_alias_decl) = 0;
/* Build result decl and add to function_decl. */
t = build_decl (UNKNOWN_LOCATION, RESULT_DECL, NULL_TREE, ptr_type_node);
DECL_CONTEXT (t) = decl;

12
gcc/config/rs6000/rs6000.c
View File

@ -23894,6 +23894,18 @@ make_resolver_func (const tree default_decl,
DECL_INITIAL (decl) = make_node (BLOCK);
DECL_STATIC_CONSTRUCTOR (decl) = 0;
if (DECL_COMDAT_GROUP (default_decl)
|| TREE_PUBLIC (default_decl))
{
/* In this case, each translation unit with a call to this
versioned function will put out a resolver. Ensure it
is comdat to keep just one copy. */
DECL_COMDAT (decl) = 1;
make_decl_one_only (decl, DECL_ASSEMBLER_NAME (decl));
}
else
TREE_PUBLIC (dispatch_decl) = 0;
/* Build result decl and add to function_decl. */
tree t = build_decl (UNKNOWN_LOCATION, RESULT_DECL, NULL_TREE, ptr_type_node);
DECL_CONTEXT (t) = decl;

4
gcc/multiple_target.c
View File

@ -178,10 +178,6 @@ create_dispatcher_calls (struct cgraph_node *node)
node->externally_visible = false;
node->forced_by_abi = false;
node->set_section (NULL);
node->unique_name = ((node->resolution == LDPR_PREVAILING_DEF_IRONLY
|| node->resolution == LDPR_PREVAILING_DEF_IRONLY_EXP)
&& !flag_incremental_link);
node->resolution = LDPR_PREVAILING_DEF_IRONLY;
DECL_ARTIFICIAL (node->decl) = 1;
node->force_output = true;

9
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,12 @@
2020-03-25 Martin Liska <mliska@suse.cz>
PR target/93274
PR ipa/94271
* gcc.target/i386/pr81213-2.c: New test.
* gcc.target/i386/pr81213.c: Add additional source.
* gcc.dg/lto/pr94271_0.c: New test.
* gcc.dg/lto/pr94271_1.c: New test.
2020-03-25 Jakub Jelinek <jakub@redhat.com>
PR debug/94280

13
gcc/testsuite/gcc.dg/lto/pr94271_0.c Normal file
View File

@ -0,0 +1,13 @@
/* PR lto/94271 */
/* { dg-lto-do link } */
int a;
static int __attribute__ ((target_clones ("default", "avx512f"))) fast_clamp ()
{}
void
c ()
{
a = fast_clamp ();
}

17
gcc/testsuite/gcc.dg/lto/pr94271_1.c Normal file
View File

@ -0,0 +1,17 @@
int aa;
static inline int __attribute__ ((target_clones ("default", "avx512f")))
fast_clamp ()
{}
void
b ()
{
aa = fast_clamp ();
}
int
main ()
{
return 0;
}

11
gcc/testsuite/gcc.target/i386/pr81213-2.c Normal file
View File

@ -0,0 +1,11 @@
__attribute__((target_clones("avx","arch=slm","arch=core-avx2","default")))
static int
foo ()
{
return 2;
}
int bar()
{
return foo();
}

7
gcc/testsuite/gcc.target/i386/pr81213.c
View File

@ -1,6 +1,9 @@
/* PR ipa/81214. */
/* { dg-do compile } */
/* { dg-do run } */
/* { dg-require-ifunc "" } */
/* { dg-additional-sources "pr81213-2.c" } */
int bar();
__attribute__((target_clones("avx","arch=slm","arch=core-avx2","default")))
static int
@ -11,7 +14,7 @@ foo ()
int main()
{
return foo();
return foo() + bar();
}
/* { dg-final { scan-assembler "\t.globl\tfoo" } } */