OpenE2K/gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

re PR tree-optimization/47190 (ICE: in function_and_variable_visibility, at ipa.c:934 with static weakref variable)

Browse Source 
PR tree-optimization/47190
	 * cgraphunit.c (process_common_attributes): New function.
        (process_function_and_variable_attributes): Use it.
	* gcc.dg/attr-weakref-3.c: New testcase.

From-SVN: r169288
This commit is contained in:
Richard Guenther 2011-01-26 14:03:54 +00:00 committed by Jan Hubicka
parent 0418e131cb
commit 768e3c602b
4 changed files with 33 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gcc/ChangeLog
View File

@ -1,3 +1,9 @@
2011-01-26 Richard Guenther <rguenther@suse.de>
PR tree-optimization/47190
* cgraphunit.c (process_common_attributes): New function.
(process_function_and_variable_attributes): Use it.
2011-01-26 Richard Guenther <rguenther@suse.de>
PR lto/47423

19
gcc/cgraphunit.c
View File

@ -791,6 +791,23 @@ cgraph_analyze_function (struct cgraph_node *node)
current_function_decl = save;
}
/* Process attributes common for vars and functions. */
static void
process_common_attributes (tree decl)
{
tree weakref = lookup_attribute ("weakref", DECL_ATTRIBUTES (decl));
if (weakref && !lookup_attribute ("alias", DECL_ATTRIBUTES (decl)))
{
warning_at (DECL_SOURCE_LOCATION (decl), OPT_Wattributes,
"%<weakref%> attribute should be accompanied with"
" an %<alias%> attribute");
DECL_WEAK (decl) = 0;
remove_attribute ("weakref", DECL_ATTRIBUTES (decl));
}
}
/* Look for externally_visible and used attributes and mark cgraph nodes
accordingly.
@ -843,6 +860,7 @@ process_function_and_variable_attributes (struct cgraph_node *first,
else if (node->local.finalized)
cgraph_mark_needed_node (node);
}
process_common_attributes (decl);
}
for (vnode = varpool_nodes; vnode != first_var; vnode = vnode->next)
{
@ -869,6 +887,7 @@ process_function_and_variable_attributes (struct cgraph_node *first,
else if (vnode->finalized)
varpool_mark_needed_node (vnode);
}
process_common_attributes (decl);
}
}

5
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2011-01-26 Richard Guenther <rguenther@suse.de>
PR tree-optimization/47190
* gcc.dg/attr-weakref-3.c: New testcase.
2011-01-26 Dave Korn <dave.korn.cygwin@gmail.com>
PR c++/43601

3
gcc/testsuite/gcc.dg/attr-weakref-3.c Normal file
View File

@ -0,0 +1,3 @@
/* { dg-do compile } */
/* { dg-require-weak "" } */
static int i __attribute__ ((weakref)); /* { dg-warning "attribute should be accompanied" } */