OpenE2K/gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

tree-optimization/98211 - fix bogus vectorization of conversion

Browse Source 
Pattern recog incompletely handles some bool cases but we shouldn't
miscompile as a result but not vectorize.  Unfortunately
vectorizable_assignment lets invalid conversions (that
vectorizable_conversion rejects) slip through.  The following
rectifies that.

2020-12-10  Richard Biener  <rguenther@suse.de>

	PR tree-optimization/98211
	* tree-vect-stmts.c (vectorizable_assignment): Disallow
	invalid conversions to bool vector types.

	* gcc.dg/pr98211.c: New testcase.
This commit is contained in:
Richard Biener 2020-12-10 11:12:53 +01:00
parent f2a5e5f3e6
commit 76c09f2af9
2 changed files with 62 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

51
gcc/testsuite/gcc.dg/pr98211.c Normal file
View File

@ -0,0 +1,51 @@
/* { dg-do run } */
/* { dg-options "-std=gnu90 -O3 -fgimple" } */
int test_var_3;
short arr_20[16];
void __GIMPLE (ssa,startwith("slp"))
test (int var_1, short int a, short int b, short int c, short int d)
{
_Bool tem2;
_Bool tem;
unsigned int i_5;
int _24;
_Bool _28;
short int _30;
short int _32;
__BB(2):
_24 = test_var_3;
tem_25 = _24 != 0;
tem2_26 = var_1_11(D) != 0;
_28 = tem_25 | tem2_26;
_30 = _28 != _Literal (_Bool) 0 ? a_16(D) : b_15(D);
arr_20[0u] = _30;
_32 = _28 != _Literal (_Bool) 0 ? c_19(D) : d_18(D);
arr_20[8u] = _32;
arr_20[1u] = _30;
arr_20[9u] = _32;
arr_20[2u] = _30;
arr_20[10u] = _32;
arr_20[3u] = _30;
arr_20[11u] = _32;
arr_20[4u] = _30;
arr_20[12u] = _32;
arr_20[5u] = _30;
arr_20[13u] = _32;
arr_20[6u] = _30;
arr_20[14u] = _32;
arr_20[7u] = _30;
arr_20[15u] = _32;
return;
}
int
main()
{
test (1, 0x88, 0x77, 0x77, 0x88);
if (arr_20[0] != 0x88)
__builtin_abort ();
return 0;
}

11
gcc/tree-vect-stmts.c
View File

@ -5123,6 +5123,17 @@ vectorizable_assignment (vec_info *vinfo,
GET_MODE_SIZE (TYPE_MODE (vectype_in)))))
return false;
if (VECTOR_BOOLEAN_TYPE_P (vectype)
&& !VECTOR_BOOLEAN_TYPE_P (vectype_in))
{
if (dump_enabled_p ())
dump_printf_loc (MSG_MISSED_OPTIMIZATION, vect_location,
"can't convert between boolean and non "
"boolean vectors %T\n", TREE_TYPE (op));
return false;
}
/* We do not handle bit-precision changes. */
if ((CONVERT_EXPR_CODE_P (code)
|| code == VIEW_CONVERT_EXPR)