OpenE2K/gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

libphobos: Don't call free on the TLS array in the emutls destroy function.

Browse Source 
Fixes a segfault seen on Darwin when a GC scan is ran after a thread has
been destroyed.  As the global emutlsArrays hash still has a reference
to the array itself, and tries to iterate all elements.

Setting the length to zero frees all allocated elements in the array,
and ensures that it is skipped when the _d_emutls_scan is called.

libphobos/ChangeLog:

	* libdruntime/gcc/emutls.d (emutlsDestroyThread): Clear the per-thread
	TLS array, don't call free().
This commit is contained in:
Iain Buclaw 2022-04-26 14:10:09 +01:00
parent 41ccd683f0
commit 796b7cbac3
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
libphobos/libdruntime/gcc/emutls.d
View File

@ -223,9 +223,9 @@ void** emutlsAlloc(shared __emutls_object* obj) nothrow @nogc
}
/*
* When a thread has finished, remove the TLS array from the GC
* scan list emutlsArrays, free all allocated TLS variables and
* finally free the array.
* When a thread has finished, free all allocated TLS variables and empty the
* array. The pointer is not free'd as it is stil referenced by the GC scan
* list emutlsArrays, which gets destroyed when druntime is unloaded.
*/
extern (C) void emutlsDestroyThread(void* ptr) nothrow @nogc
{
@ -237,7 +237,7 @@ extern (C) void emutlsDestroyThread(void* ptr) nothrow @nogc
free(entry[-1]);
}
free(arr);
arr.length = 0;
}
/*