OpenE2K/gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

PR tree-optimization/97546 Bail out of find_bswap_or_nop on non-INTEGER_CST sizes

Browse Source 
This patch fixes the ICE in the PR by bailing out of find_bswap_or_nop
on poly_int sizes.
I don't think it intends to handle them and from my reading of the code
it's the most appropriate place to reject them
here rather than in the callers.

Bootstrapped and tested on aarch64-none-linux-gnu.

gcc/
	PR tree-optimization/97546
	* gimple-ssa-store-merging.c (find_bswap_or_nop): Return NULL if
	type is not INTEGER_CST.

gcc/testsuite/
	PR tree-optimization/97546
	* gcc.target/aarch64/sve/acle/general/pr97546.c: New test.
This commit is contained in:
Kyrylo Tkachov 2020-10-26 11:42:18 +00:00
parent 605c2a393d
commit 7f0ce82a4c
2 changed files with 27 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gcc/gimple-ssa-store-merging.c
View File

@ -851,12 +851,16 @@ find_bswap_or_nop_finalize (struct symbolic_number *n, uint64_t *cmpxchg,
gimple *
find_bswap_or_nop (gimple *stmt, struct symbolic_number *n, bool *bswap)
{
tree type_size = TYPE_SIZE_UNIT (gimple_expr_type (stmt));
if (!tree_fits_uhwi_p (type_size))
return NULL;
/* The last parameter determines the depth search limit. It usually
correlates directly to the number n of bytes to be touched. We
increase that number by 2 * (log2(n) + 1) here in order to also
cover signed -> unsigned conversions of the src operand as can be seen
in libgcc, and for initial shift/and operation of the src operand. */
int limit = TREE_INT_CST_LOW (TYPE_SIZE_UNIT (gimple_expr_type (stmt)));
int limit = tree_to_uhwi (type_size);
limit += 2 * (1 + (int) ceil_log2 ((unsigned HOST_WIDE_INT) limit));
gimple *ins_stmt = find_bswap_or_nop_1 (stmt, n, limit);

22
gcc/testsuite/gcc.target/aarch64/sve/acle/general/pr97546.c Normal file
View File

@ -0,0 +1,22 @@
/* { dg-options "-O2" } */
#include <arm_sve.h>
static svbool_t visinf_vo_vf(svfloat32_t d)
{
return svcmpeq_n_f32 (svptrue_b8 (),
svabs_f32_x (svptrue_b8 (), d),
__builtin_inff ());
}
const svint32_t _ZGVsNxv_ilogbf(svfloat32_t d)
{
svint32_t e = svreinterpret_s32_f32 (svdup_n_f32 (0.0f));
e = svsel_s32 (svcmpne_f32 (svptrue_b8(), d, d),
svdup_n_s32 (2147483647),
e);
e = svsel_s32 (visinf_vo_vf (d),
svdup_n_s32 (0x7fffffff),
e);
return e;
}