From 7f3915b83ed37516a2ff84eb3a6a6e37d3fc9a15 Mon Sep 17 00:00:00 2001 From: Jakub Jelinek Date: Wed, 19 Jan 2022 12:22:02 +0100 Subject: [PATCH] rs6000: Fix bootstrap MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit > On 18/01/2022 22:42, Segher Boessenkool wrote: > > > + default: > > > + break; > > Please don't do that. You can do > > > > default: > > break; > > break; > > /* And just to make sure: */ > > break; > > break; > > > > and it will do exactly the same as not having a default at all. Not > > having such useless code is by far the most readable, so please don't > > include a default case at all. > > I removed the default case. I hope this is what you wanted. Unfortunately the removal of default: break; breaks bootstrap: ../../gcc/config/rs6000/rs6000.cc: In function ‘const char* rs6000_machine_from_flags()’: ../../gcc/config/rs6000/rs6000.cc:5940:10: error: enumeration value ‘PROCESSOR_PPC601’ not handled in switch [-Werror=switch] 5940 | switch (rs6000_cpu) | ^ ../../gcc/config/rs6000/rs6000.cc:5940:10: error: enumeration value ‘PROCESSOR_PPC603’ not handled in switch [-Werror=switch] ... default: break; is needed to tell the -Wswitch warning that it is intentional that not all enumerators are handled in the switch. 2022-01-19 Jakub Jelinek * config/rs6000/rs6000.cc (rs6000_machine_from_flags): Add default:. --- gcc/config/rs6000/rs6000.cc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gcc/config/rs6000/rs6000.cc b/gcc/config/rs6000/rs6000.cc index 2a338a222c1..d37775ece84 100644 --- a/gcc/config/rs6000/rs6000.cc +++ b/gcc/config/rs6000/rs6000.cc @@ -5958,6 +5958,9 @@ rs6000_machine_from_flags (void) case PROCESSOR_PPCE6500: return "e6500"; + + default: + break; } HOST_WIDE_INT flags = rs6000_isa_flags;