OpenE2K/gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

re PR c++/19618 (Do warn if a bit-field exceeds the size of a bool type)

Browse Source 
/cp
2013-05-24  Paolo Carlini  <paolo.carlini@oracle.com>

	PR c++/19618
	* class.c (check_bitfield_decl): Warn for bool and enum bitfields
	with width exceeding the type.

/testsuite
2013-05-24  Paolo Carlini  <paolo.carlini@oracle.com>

	PR c++/19618
	* g++.dg/expr/bitfield12.C: New.

From-SVN: r199306
This commit is contained in:
Paolo Carlini 2013-05-24 17:37:41 +00:00 committed by Paolo Carlini
parent 2343af6558
commit 7f5d76fb97
4 changed files with 36 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gcc/cp/ChangeLog
View File

@ -1,3 +1,9 @@
2013-05-24 Paolo Carlini <paolo.carlini@oracle.com>
PR c++/19618
* class.c (check_bitfield_decl): Warn for bool and enum bitfields
with width exceeding the type.
2013-05-24 Jason Merrill <jason@redhat.com>
PR c++/57391

9
gcc/cp/class.c
View File

@ -3140,9 +3140,12 @@ check_bitfield_decl (tree field)
error ("zero width for bit-field %q+D", field);
w = error_mark_node;
}
else if (compare_tree_int (w, TYPE_PRECISION (type)) > 0
&& TREE_CODE (type) != ENUMERAL_TYPE
&& TREE_CODE (type) != BOOLEAN_TYPE)
else if ((TREE_CODE (type) != ENUMERAL_TYPE
&& TREE_CODE (type) != BOOLEAN_TYPE
&& compare_tree_int (w, TYPE_PRECISION (type)) > 0)
|| ((TREE_CODE (type) == ENUMERAL_TYPE
|| TREE_CODE (type) == BOOLEAN_TYPE)
&& tree_int_cst_lt (TYPE_SIZE (type), w)))
warning (0, "width of %q+D exceeds its type", field);
else if (TREE_CODE (type) == ENUMERAL_TYPE
&& (0 > (compare_tree_int

5
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2013-05-24 Paolo Carlini <paolo.carlini@oracle.com>
PR c++/19618
* g++.dg/expr/bitfield12.C: New.
2013-05-24 Jeff Law <law@redhat.com>
PR tree-optimization/57124

19
gcc/testsuite/g++.dg/expr/bitfield12.C Normal file
View File

@ -0,0 +1,19 @@
// PR c++/19618
struct bset1 {
bool bit : sizeof(bool) * __CHAR_BIT__ + 1; // { dg-warning "exceeds" }
};
enum E {};
struct bset2 {
E bit : sizeof(E) * __CHAR_BIT__ + 1; // { dg-warning "exceeds" }
};
struct bset3 {
bool bit : sizeof(bool) * __CHAR_BIT__;
};
struct bset4 {
E bit : sizeof(E) * __CHAR_BIT__;
};