OpenE2K
/
gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

re PR middle-end/52244 (wrong code for function returning union between int and _Bool at O > 2, with no-early-inlining) 

2012-02-14  Richard Guenther  <rguenther@suse.de>

	PR tree-optimization/52244
	PR tree-optimization/51528
	* tree-sra.c (analyze_access_subtree): Only create INTEGER_TYPE
	replacements for integral types.

	* gcc.dg/torture/pr52244.c: New testcase.

From-SVN: r184214
This commit is contained in:
Richard Guenther 2012-02-14 15:33:56 +00:00 committed by Richard Biener
parent 31772c9507
commit 8085c58661
4 changed files with 61 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gcc/ChangeLog
View File

@ -1,3 +1,10 @@
2012-02-14 Richard Guenther <rguenther@suse.de>
PR tree-optimization/52244
PR tree-optimization/51528
* tree-sra.c (analyze_access_subtree): Only create INTEGER_TYPE
replacements for integral types.
2012-02-14 Walter Lee <walt@tilera.com>
* config.gcc: Handle tilegx and tilepro.

6
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,9 @@
2012-02-14 Richard Guenther <rguenther@suse.de>
PR tree-optimization/52244
PR tree-optimization/51528
* gcc.dg/torture/pr52244.c: New testcase.
2012-02-14 Walter Lee <walt@tilera.com>
* g++.dg/other/PR23205.C: Disable test on tile.

36
gcc/testsuite/gcc.dg/torture/pr52244.c Normal file
View File

@ -0,0 +1,36 @@
/* { dg-do run } */
extern void abort (void);
typedef union u_r
{
_Bool b;
unsigned char c;
} u_t;
u_t
bar (void)
{
u_t u;
u.c = 0x12;
return u;
}
u_t __attribute__ ((noinline))
foo (void)
{
u_t u;
u.b = 1;
u = bar ();
return u;
}
int main (int argc, char **argv)
{
u_t u = foo ();
if (u.c != 0x12)
abort ();
return 0;
}

14
gcc/tree-sra.c
View File

@ -2172,11 +2172,21 @@ analyze_access_subtree (struct access *root, struct access *parent,
&& (root->grp_scalar_write || root->grp_assignment_write))))
{
bool new_integer_type;
if (TREE_CODE (root->type) == ENUMERAL_TYPE)
/* Always create access replacements that cover the whole access.
For integral types this means the precision has to match.
Avoid assumptions based on the integral type kind, too. */
if (INTEGRAL_TYPE_P (root->type)
&& (TREE_CODE (root->type) != INTEGER_TYPE
|| TYPE_PRECISION (root->type) != root->size)
/* But leave bitfield accesses alone. */
&& (root->offset % BITS_PER_UNIT) == 0)
{
tree rt = root->type;
root->type = build_nonstandard_integer_type (TYPE_PRECISION (rt),
root->type = build_nonstandard_integer_type (root->size,
TYPE_UNSIGNED (rt));
root->expr = build_ref_for_offset (UNKNOWN_LOCATION,
root->base, root->offset,
root->type, NULL, false);
new_integer_type = true;
}
else