OpenE2K/gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

re PR c++/35337 (Broken diagnostic for firstprivate clause)

Browse Source 
PR c++/35337
	* semantics.c (finish_omp_clauses): Use %qD instead of %qE for
	DECL_P in not a variable and appears more than once error messages.

	* g++.dg/gomp/pr35337.C: New test.

From-SVN: r133086
This commit is contained in:
Jakub Jelinek 2008-03-10 20:43:16 +01:00 committed by Jakub Jelinek
parent 5df27e4a3e
commit 85b20612e7
4 changed files with 39 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gcc/cp/ChangeLog
View File

@ -1,3 +1,9 @@
2008-03-10 Jakub Jelinek <jakub@redhat.com>
PR c++/35337
* semantics.c (finish_omp_clauses): Use %qD instead of %qE for
DECL_P in not a variable and appears more than once error messages.
2008-03-07 Paolo Bonzini <bonzini@gnu.org>
Revert:

14
gcc/cp/semantics.c
View File

@ -3400,13 +3400,16 @@ finish_omp_clauses (tree clauses)
{
if (processing_template_decl)
break;
error ("%qE is not a variable in clause %<firstprivate%>", t);
if (DECL_P (t))
error ("%qD is not a variable in clause %<firstprivate%>", t);
else
error ("%qE is not a variable in clause %<firstprivate%>", t);
remove = true;
}
else if (bitmap_bit_p (&generic_head, DECL_UID (t))
|| bitmap_bit_p (&firstprivate_head, DECL_UID (t)))
{
error ("%qE appears more than once in data clauses", t);
error ("%qD appears more than once in data clauses", t);
remove = true;
}
else
@ -3419,13 +3422,16 @@ finish_omp_clauses (tree clauses)
{
if (processing_template_decl)
break;
error ("%qE is not a variable in clause %<lastprivate%>", t);
if (DECL_P (t))
error ("%qD is not a variable in clause %<lastprivate%>", t);
else
error ("%qE is not a variable in clause %<lastprivate%>", t);
remove = true;
}
else if (bitmap_bit_p (&generic_head, DECL_UID (t))
|| bitmap_bit_p (&lastprivate_head, DECL_UID (t)))
{
error ("%qE appears more than once in data clauses", t);
error ("%qD appears more than once in data clauses", t);
remove = true;
}
else

3
gcc/testsuite/ChangeLog
View File

@ -1,5 +1,8 @@
2008-03-10 Jakub Jelinek <jakub@redhat.com>
PR c++/35337
* g++.dg/gomp/pr35337.C: New test.
PR c/35438
PR c/35439
* gcc.dg/gomp/pr35438.c: New test.

20
gcc/testsuite/g++.dg/gomp/pr35337.C Normal file
View File

@ -0,0 +1,20 @@
// PR c++/35337
// { dg-do compile }
// { dg-options "-fopenmp" }
struct A { };
void
foo ()
{
#pragma omp parallel firstprivate(A) // { dg-error "struct A\[^\n\]*is not a variable" }
;
}
void
bar ()
{
#pragma omp for lastprivate(A) // { dg-error "struct A\[^\n\]*is not a variable" }
for (int i = 0; i < 10; i++)
;
}