OpenE2K
/
gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

d: Add -Wvarargs warning flag to the D front-end 

The D front-end has C-style variadic functions and va_start/va_arg, so
it is right to also have warnings for inproper use.

gcc/d/ChangeLog:

	PR d/96154
	* gdc.texi (Warnings): Document -Wvarargs.
	* lang.opt: Add -Wvarargs

gcc/testsuite/ChangeLog:

	PR d/96154
	* gdc.dg/pr96154a.d: New test.
	* gdc.dg/pr96154b.d: New test.
This commit is contained in:
Iain Buclaw 2020-07-16 18:56:18 +02:00
parent dfc420f8d4
commit 873b45d39c
4 changed files with 47 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gcc/d/gdc.texi
View File

@ -600,6 +600,12 @@ Warn when a @code{pragma()} is encountered that is not understood by
where a pragma that is part of the D language, but not implemented by
the compiler, won't get reported.
@item -Wno-varargs
@cindex Wvarargs
@cindex Wno-varargs
Do not warn upon questionable usage of the macros used to handle variable
arguments like @code{va_start}.
@item -fignore-unknown-pragmas
@cindex @option{-fignore-unknown-pragmas}
@cindex @option{-fno-ignore-unknown-pragmas}

4
gcc/d/lang.opt
View File

@ -146,6 +146,10 @@ Wunknown-pragmas
D LangEnabledBy(D, Wall)
; Documented in C
Wvarargs
D
; Documented in C
X
D
Generate JSON file.

18
gcc/testsuite/gdc.dg/pr96154a.d Normal file
View File

@ -0,0 +1,18 @@
// { dg-do compile }
import core.stdc.stdarg;
void
error (int a)
{
va_list vp;
va_start (vp, a); // { dg-error "used in function with fixed arguments" }
}
void
warn (int a, int b, ...)
{
va_list vp;
va_start (vp, a); // { dg-warning "second parameter" }
va_end (vp);
}

19
gcc/testsuite/gdc.dg/pr96154b.d Normal file
View File

@ -0,0 +1,19 @@
// { dg-options "-Wno-varargs" }
// { dg-do compile }
import core.stdc.stdarg;
void
error (int a)
{
va_list vp;
va_start (vp, a); // { dg-error "used in function with fixed arguments" }
}
void
warn (int a, int b, ...)
{
va_list vp;
va_start (vp, a); // No warning because of -Wno-varargs in effect.
va_end (vp);
}