From 8887fa10785a8a7788e86db18dc54f7470ff4b0f Mon Sep 17 00:00:00 2001 From: Jakub Jelinek Date: Thu, 22 Jun 2017 00:19:38 +0200 Subject: [PATCH] re PR c++/81130 (ICE OpenMP shared clause in gimplify_var_or_parm_decl, at gimplify.c:2584) PR c++/81130 * gimplify.c (omp_add_variable): Don't force GOVD_SEEN for types with ctors/dtors if GOVD_SHARED is set. * testsuite/libgomp.c++/pr81130.C: New test. From-SVN: r249482 --- gcc/ChangeLog | 4 +++ gcc/gimplify.c | 8 +++-- libgomp/ChangeLog | 5 +++ libgomp/testsuite/libgomp.c++/pr81130.C | 41 +++++++++++++++++++++++++ 4 files changed, 55 insertions(+), 3 deletions(-) create mode 100644 libgomp/testsuite/libgomp.c++/pr81130.C diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 266ce7e147f..71e3531e044 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,5 +1,9 @@ 2017-06-21 Jakub Jelinek + PR c++/81130 + * gimplify.c (omp_add_variable): Don't force GOVD_SEEN for types + with ctors/dtors if GOVD_SHARED is set. + Backported from mainline 2017-06-20 Jakub Jelinek diff --git a/gcc/gimplify.c b/gcc/gimplify.c index f98a2836489..b93993c7856 100644 --- a/gcc/gimplify.c +++ b/gcc/gimplify.c @@ -6608,9 +6608,11 @@ omp_add_variable (struct gimplify_omp_ctx *ctx, tree decl, unsigned int flags) return; /* Never elide decls whose type has TREE_ADDRESSABLE set. This means - there are constructors involved somewhere. */ - if (TREE_ADDRESSABLE (TREE_TYPE (decl)) - || TYPE_NEEDS_CONSTRUCTING (TREE_TYPE (decl))) + there are constructors involved somewhere. Exception is a shared clause, + there is nothing privatized in that case. */ + if ((flags & GOVD_SHARED) == 0 + && (TREE_ADDRESSABLE (TREE_TYPE (decl)) + || TYPE_NEEDS_CONSTRUCTING (TREE_TYPE (decl)))) flags |= GOVD_SEEN; n = splay_tree_lookup (ctx->variables, (splay_tree_key)decl); diff --git a/libgomp/ChangeLog b/libgomp/ChangeLog index 9ddbc91fdba..30663e160ad 100644 --- a/libgomp/ChangeLog +++ b/libgomp/ChangeLog @@ -1,3 +1,8 @@ +2017-06-21 Jakub Jelinek + + PR c++/81130 + * testsuite/libgomp.c++/pr81130.C: New test. + 2017-06-02 Jakub Jelinek Backported from mainline diff --git a/libgomp/testsuite/libgomp.c++/pr81130.C b/libgomp/testsuite/libgomp.c++/pr81130.C new file mode 100644 index 00000000000..f2cb571294d --- /dev/null +++ b/libgomp/testsuite/libgomp.c++/pr81130.C @@ -0,0 +1,41 @@ +// PR c++/81130 +// { dg-do run } + +struct A +{ + A (); + ~A (); + int a; +}; + +A::A () +{ + a = 0; +} + +A::~A () +{ +} + +struct B +{ + A b; + int c; + B () : c (1) + { +#pragma omp parallel shared (b, c) num_threads (2) +#pragma omp master + { + b.a++; + c += 2; + } + } +}; + +int +main () +{ + B v; + if (v.b.a != 1 || v.c != 3) + __builtin_abort (); +}