OpenE2K/gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

compiler: Logical operators should yield untyped bool for untyped operands.

Browse Source 
Fixes issue 6671 for gccgo.

From-SVN: r217094
This commit is contained in:
Ian Lance Taylor 2014-11-04 17:49:01 +00:00
parent 4456c6bff2
commit 8b06e1880e
2 changed files with 3 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
gcc/go/gofrontend/expressions.cc
View File

@ -5314,15 +5314,6 @@ Binary_expression::do_determine_type(const Type_context* context)
subcontext.type = NULL;
}
if (this->op_ == OPERATOR_ANDAND || this->op_ == OPERATOR_OROR)
{
// For a logical operation, the context does not determine the
// types of the operands. The operands must be some boolean
// type but if the context has a boolean type they do not
// inherit it. See http://golang.org/issue/3924.
subcontext.type = NULL;
}
// Set the context for the left hand operand.
if (is_shift_op)
{

6
gcc/testsuite/go.test/test/fixedbugs/issue3924.go
View File

@ -1,4 +1,4 @@
// errorcheck
// compile
// Copyright 2012 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
@ -9,5 +9,5 @@ package foo
type mybool bool
var x, y = 1, 2
var _ mybool = x < y && x < y // ERROR "cannot use"
var _ mybool = x < y || x < y // ERROR "cannot use"
var _ mybool = x < y && x < y
var _ mybool = x < y || x < y