diff --git a/gcc/ada/ChangeLog b/gcc/ada/ChangeLog index e729f1851fe..8233aa4a7fe 100644 --- a/gcc/ada/ChangeLog +++ b/gcc/ada/ChangeLog @@ -1,3 +1,9 @@ +2018-04-04 Ed Schonberg + + * sem_attr.adb (Analyze_Attribute, case Scalar_Storage_Order): The + attribute reference is legal within a generic unit when the prefix is a + formal private type. + 2018-04-04 Hristian Kirtchev * exp_ch7.adb (Establish_Transient_Scope): Code cleanup. Do not diff --git a/gcc/ada/sem_attr.adb b/gcc/ada/sem_attr.adb index f3824a8bb1a..9cc3055a6d2 100644 --- a/gcc/ada/sem_attr.adb +++ b/gcc/ada/sem_attr.adb @@ -5709,11 +5709,15 @@ package body Sem_Attr is if not (Is_Record_Type (P_Type) or else Is_Array_Type (P_Type)) then - -- In GNAT mode, the attribute applies to generic types as well - -- as composite types, and for non-composite types always returns - -- the default bit order for the target. + -- The attribute applies to generic private types (in which case + -- the legality rule is applied in the instance) as well as to + -- composite types. For noncomposite types it always returns the + -- default bit order for the target. + -- Allowing formal private types was originally introduced in + -- GNAT_Mode only, to compile instances of Sequential_IO, but + -- users find it more generally useful in generic units. - if not (GNAT_Mode and then Is_Generic_Type (P_Type)) + if not (Is_Generic_Type (P_Type) and then Is_Private_Type (P_Type)) and then not In_Instance then Error_Attr_P @@ -11074,7 +11078,7 @@ package body Sem_Attr is -- The context may be a constrained access type (however ill- -- advised such subtypes might be) so in order to generate a - -- constraint check when needed set the type of the attribute + -- constraint check we need to set the type of the attribute -- reference to the base type of the context. Set_Etype (N, Btyp); @@ -11837,6 +11841,8 @@ package body Sem_Attr is if Attr_Id = Attribute_Elaborated then null; + -- Should this be restricted to Expander_Active??? + else Freeze_Expression (P); end if;