OpenE2K/gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

libstdc++: Fix out-of-bound array accesses in testsuite

Browse Source 
I fixed some undefined behaviour in string tests in r238609, but I only
fixed the narrow char versions. This applies the same fixes to the
wchar_t ones. These problems were found when testing a patch to make
std::basic_string usable in constexpr.

libstdc++-v3/ChangeLog:

	* testsuite/21_strings/basic_string/modifiers/append/wchar_t/1.cc:
	Fix reads past the end of strings.
	* testsuite/21_strings/basic_string/operations/compare/wchar_t/1.cc:
	Likewise.
	* testsuite/experimental/string_view/operations/compare/wchar_t/1.cc:
	Likewise.
This commit is contained in:
Jonathan Wakely 2016-07-21 20:38:51 +01:00
parent 9719769471
commit 8d8e8f3ad5
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libstdc++-v3/testsuite/21_strings/basic_string/modifiers/append/wchar_t/1.cc
View File

@ -117,7 +117,7 @@ void test01(void)
VERIFY( str06 == L"corpus, corpus" );
str06 = str02;
str06.append(L"corpus, ", 12);
str06.append(L"corpus, ", 9); // n=9 includes null terminator
VERIFY( str06 != L"corpus, corpus, " );

4
libstdc++-v3/testsuite/21_strings/basic_string/operations/compare/wchar_t/1.cc
View File

@ -81,8 +81,8 @@ test01()
test_value(wcsncmp(str_1.data(), str_0.data(), 6), z);
test_value(wcsncmp(str_1.data(), str_0.data(), 14), lt);
test_value(wmemcmp(str_1.data(), str_0.data(), 6), z);
test_value(wmemcmp(str_1.data(), str_0.data(), 14), lt);
test_value(wmemcmp(L"costa marbella", L"costa rica", 14), lt);
test_value(wmemcmp(str_1.data(), str_0.data(), 10), lt);
test_value(wmemcmp(L"costa marbella", L"costa rica", 10), lt);
// int compare(const basic_string& str) const;
test_value(str_0.compare(str_1), gt); //because r>m

4
libstdc++-v3/testsuite/experimental/string_view/operations/compare/wchar_t/1.cc
View File

@ -81,8 +81,8 @@ test01()
test_value(wcsncmp(str_1.data(), str_0.data(), 6), z);
test_value(wcsncmp(str_1.data(), str_0.data(), 14), lt);
test_value(wmemcmp(str_1.data(), str_0.data(), 6), z);
test_value(wmemcmp(str_1.data(), str_0.data(), 14), lt);
test_value(wmemcmp(L"costa marbella", L"costa rica", 14), lt);
test_value(wmemcmp(str_1.data(), str_0.data(), 10), lt);
test_value(wmemcmp(L"costa marbella", L"costa rica", 10), lt);
// int compare(const basic_string_view& str) const;
test_value(str_0.compare(str_1), gt); //because r>m