OpenE2K/gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

compiler: Check for calling value method with dereferenced value.

Browse Source 
From-SVN: r183379
This commit is contained in:
Ian Lance Taylor 2012-01-21 22:21:22 +00:00
parent 98dfd7ff16
commit 8f94383a99
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
gcc/go/gofrontend/types.cc
View File

@ -8605,6 +8605,7 @@ Type::bind_field_or_method(Gogo* gogo, const Type* type, Expression* expr,
// If this is a pointer to a pointer, then it is possible that the
// pointed-to type has methods.
bool dereferenced = false;
if (nt == NULL
&& st == NULL
&& it == NULL
@ -8617,6 +8618,7 @@ Type::bind_field_or_method(Gogo* gogo, const Type* type, Expression* expr,
return Expression::make_error(location);
nt = type->points_to()->named_type();
st = type->points_to()->struct_type();
dereferenced = true;
}
bool receiver_can_be_pointer = (expr->type()->points_to() != NULL
@ -8656,6 +8658,12 @@ Type::bind_field_or_method(Gogo* gogo, const Type* type, Expression* expr,
else
go_unreachable();
go_assert(m != NULL);
if (dereferenced && m->is_value_method())
{
error_at(location,
"calling value method requires explicit dereference");
return Expression::make_error(location);
}
if (!m->is_value_method() && expr->type()->points_to() == NULL)
expr = Expression::make_unary(OPERATOR_AND, expr, location);
ret = m->bind_method(expr, location);