OpenE2K
/
gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

c-warn.c (find_array_ref_with_const_idx_r): Remove parameter names. 

* c-warn.c (find_array_ref_with_const_idx_r): Remove parameter names.
	Return immediately when finding a match.
	(warn_tautological_cmp): Remove a boolean variable that is no longer
	needed.

From-SVN: r241278
This commit is contained in:
Marek Polacek 2016-10-17 19:29:00 +00:00 committed by Marek Polacek
parent 1d30acf687
commit 8fa18c06a2
2 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gcc/c-family/ChangeLog
View File

@ -1,3 +1,10 @@
2016-10-17 Marek Polacek <polacek@redhat.com>
* c-warn.c (find_array_ref_with_const_idx_r): Remove parameter names.
Return immediately when finding a match.
(warn_tautological_cmp): Remove a boolean variable that is no longer
needed.
2016-10-17 Marek Polacek <polacek@redhat.com>
* c-attribs.c: New file.

13
gcc/c-family/c-warn.c
View File

@ -256,17 +256,14 @@ warn_logical_operator (location_t location, enum tree_code code, tree type,
with constant indices. */
static tree
find_array_ref_with_const_idx_r (tree *expr_p, int *walk_subtrees, void *data)
find_array_ref_with_const_idx_r (tree *expr_p, int *, void *)
{
tree expr = *expr_p;
if ((TREE_CODE (expr) == ARRAY_REF
|| TREE_CODE (expr) == ARRAY_RANGE_REF)
&& TREE_CODE (TREE_OPERAND (expr, 1)) == INTEGER_CST)
{
*(bool *) data = true;
*walk_subtrees = 0;
}
return integer_type_node;
return NULL_TREE;
}
@ -312,10 +309,8 @@ warn_tautological_cmp (location_t loc, enum tree_code code, tree lhs, tree rhs)
{
/* Don't warn about array references with constant indices;
these are likely to come from a macro. */
bool found = false;
walk_tree_without_duplicates (&lhs, find_array_ref_with_const_idx_r,
&found);
if (found)
if (walk_tree_without_duplicates (&lhs, find_array_ref_with_const_idx_r,
NULL))
return;
const bool always_true = (code == EQ_EXPR || code == LE_EXPR
|| code == GE_EXPR || code == UNLE_EXPR