OpenE2K/gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[asan] Fix a thinko leading to a crash

Browse Source 
It appeared that in my previous patch, a stupid thinko can lead to a
crash when instrumenting some builtin functionsK.  Fixed thus.

Bootstrapped and tested against trunk on x86_64-unknown-linux-gnu.

gcc/
	* asan.c (instrument_builtin_call):  Really put the length of the
	second source argument into src1_len.

gcc/testsuite/

	* c-c++-common/asan/memcmp-2.c: New test.

From-SVN: r196044
This commit is contained in:
Dodji Seketeli 2013-02-14 04:37:56 +00:00 committed by Dodji Seketeli
parent 28d5c77761
commit 8fb067263b
4 changed files with 22 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gcc/ChangeLog
View File

@ -1,3 +1,9 @@
2013-02-14 Dodji Seketeli <dodji@redhat.com>
Fix an asan crash
* asan.c (instrument_builtin_call): Really put the length of the
second source argument into src1_len.
2013-02-13 Jakub Jelinek <jakub@redhat.com>
* asan.c (create_cond_insert_point): Add create_then_fallthru_edge

2
gcc/asan.c
View File

@ -1771,7 +1771,7 @@ instrument_builtin_call (gimple_stmt_iterator *iter)
if (get_mem_refs_of_builtin_call (call,
&src0, &src0_len, &src0_is_store,
&src1, &src0_len, &src1_is_store,
&src1, &src1_len, &src1_is_store,
&dest, &dest_len, &dest_is_store,
&dest_is_deref))
{

5
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2013-02-14 Dodji Seketeli <dodji@redhat.com>
Fix an asan crash
* c-c++-common/asan/memcmp-2.c: New test.
2013-02-13 Ed Smith-Rowland <3dw4rd@verizon.net>
PR c++/55582

10
gcc/testsuite/c-c++-common/asan/memcmp-2.c Normal file
View File

@ -0,0 +1,10 @@
/* { dg-do compile } */
int
foo ()
{
char s0[5] = {0};
char s1[5] = {1};
return __builtin_memcmp (s0, s1, 2);
}