OpenE2K
/
gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

re PR c++/48420 (Missed -Wconversion-null warning when passing const bool to T*) 

/cp
2011-11-04  Paolo Carlini  <paolo.carlini@oracle.com>

	PR c++/48420
	* call.c (conversion_null_warnings): For 'false' to NULL pointer,
	just check that TREE_TYPE (expr) is a BOOLEAN_TYPE.

/testsuite
2011-11-04  Paolo Carlini  <paolo.carlini@oracle.com>

	PR c++/48420
	* g++.dg/warn/Wconversion-null-3.C: New.

From-SVN: r180963
This commit is contained in:
Paolo Carlini 2011-11-04 16:31:18 +00:00 committed by Paolo Carlini
parent e4fe948a6e
commit 92b4d64cd4
4 changed files with 21 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gcc/cp/ChangeLog
View File

@ -1,3 +1,9 @@
2011-11-04 Paolo Carlini <paolo.carlini@oracle.com>
PR c++/48420
* call.c (conversion_null_warnings): For 'false' to NULL pointer,
just check that TREE_TYPE (expr) is a BOOLEAN_TYPE.
2011-11-04 Ed Smith-Rowland <3dw4rd@verizon.net>
PR c++/50941

3
gcc/cp/call.c
View File

@ -5544,7 +5544,8 @@ conversion_null_warnings (tree totype, tree expr, tree fn, int argnum)
}
/* Issue warnings if "false" is converted to a NULL pointer */
else if (expr == boolean_false_node && TYPE_PTR_P (totype))
else if (TREE_CODE (TREE_TYPE (expr)) == BOOLEAN_TYPE
&& TYPE_PTR_P (totype))
{
if (fn)
warning_at (input_location, OPT_Wconversion_null,

5
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2011-11-04 Paolo Carlini <paolo.carlini@oracle.com>
PR c++/48420
* g++.dg/warn/Wconversion-null-3.C: New.
2011-11-04 Ed Smith-Rowland <3dw4rd@verizon.net>
PR c++/50941

8
gcc/testsuite/g++.dg/warn/Wconversion-null-3.C Normal file
View File

@ -0,0 +1,8 @@
// PR c++/48420
void foo(int* p);
void bar() {
const bool kDebugMode = false;
foo(kDebugMode); // { dg-warning "converting 'false'" }
}