OpenE2K
/
gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

re PR c/70671 (Wrong column number shown for "error: cannot take address of bit-field") 

PR c/70671
	* c-typeck.c (build_unary_op): Pass location down to error and
	warning call.

	* gcc.dg/bitfld-22.c: New test.

From-SVN: r235032
This commit is contained in:
Marek Polacek 2016-04-15 14:46:06 +00:00 committed by Marek Polacek
parent fab0ad9253
commit 949505a900
4 changed files with 36 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gcc/c/ChangeLog
View File

@ -1,3 +1,9 @@
2016-04-15 Marek Polacek <polacek@redhat.com>
PR c/70671
* c-typeck.c (build_unary_op): Pass location down to error and
warning call.
2016-04-15 Jakub Jelinek <jakub@redhat.com>
PR c/70436

13
gcc/c/c-typeck.c
View File

@ -4436,8 +4436,8 @@ build_unary_op (location_t location,
case COMPONENT_REF:
if (DECL_C_BIT_FIELD (TREE_OPERAND (arg, 1)))
{
error ("cannot take address of bit-field %qD",
TREE_OPERAND (arg, 1));
error_at (location, "cannot take address of bit-field %qD",
TREE_OPERAND (arg, 1));
return error_mark_node;
}
@ -4449,15 +4449,16 @@ build_unary_op (location_t location,
if (!AGGREGATE_TYPE_P (TREE_TYPE (arg))
&& !VECTOR_TYPE_P (TREE_TYPE (arg)))
{
error ("cannot take address of scalar with reverse storage "
"order");
error_at (location, "cannot take address of scalar with "
"reverse storage order");
return error_mark_node;
}
if (TREE_CODE (TREE_TYPE (arg)) == ARRAY_TYPE
&& TYPE_REVERSE_STORAGE_ORDER (TREE_TYPE (arg)))
warning (OPT_Wscalar_storage_order, "address of array with "
"reverse scalar storage order requested");
warning_at (location, OPT_Wscalar_storage_order,
"address of array with reverse scalar storage "
"order requested");
}
default:

5
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2016-04-15 Marek Polacek <polacek@redhat.com>
PR c/70671
* gcc.dg/bitfld-22.c: New test.
2016-04-15 Bernd Schmidt <bschmidt@redhat.com>
* gcc.target/i386/pr46470.c: Add -mno-red-zone to dg-options for

18
gcc/testsuite/gcc.dg/bitfld-22.c Normal file
View File

@ -0,0 +1,18 @@
/* PR c/70671 */
/* { dg-do compile } */
extern void bar (int *);
struct S
{
int x:2;
} s, *r;
void
foo (void)
{
int *p1 = &s.x; /* { dg-error "13:cannot take address of bit-field 'x'" } */
int *p2;
p2 = &s.x; /* { dg-error "8:cannot take address of bit-field 'x'" } */
bar (&s.x); /* { dg-error "8:cannot take address of bit-field 'x'" } */
}