OpenE2K
/
gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

aarch64: Fix up RTL sharing bug in aarch64_load_symref_appropriately [PR104910] 

We unshare all RTL created during expansion, but when
aarch64_load_symref_appropriately is called after expansion like in the
following testcases, we use imm in both HIGH and LO_SUM operands.
If imm is some RTL that shouldn't be shared like a non-sharable CONST,
we get at least with --enable-checking=rtl a checking ICE, otherwise might
just get silently wrong code.

The following patch fixes that by copying it if it can't be shared.

2022-03-16  Jakub Jelinek  <jakub@redhat.com>

	PR target/104910
	* config/aarch64/aarch64.cc (aarch64_load_symref_appropriately): Copy
	imm rtx.

	* gcc.dg/pr104910.c: New test.
This commit is contained in:
Jakub Jelinek 2022-03-16 11:04:16 +01:00
parent 6aef670e48
commit 952155629c
2 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gcc/config/aarch64/aarch64.cc
View File

@ -3971,7 +3971,7 @@ aarch64_load_symref_appropriately (rtx dest, rtx imm,
if (can_create_pseudo_p ())
tmp_reg = gen_reg_rtx (mode);
emit_move_insn (tmp_reg, gen_rtx_HIGH (mode, imm));
emit_move_insn (tmp_reg, gen_rtx_HIGH (mode, copy_rtx (imm)));
emit_insn (gen_add_losym (dest, tmp_reg, imm));
return;
}

14
gcc/testsuite/gcc.dg/pr104910.c Normal file
View File

@ -0,0 +1,14 @@
/* PR target/104910 */
/* { dg-do compile } */
/* { dg-options "-Os -fno-forward-propagate" } */
/* { dg-additional-options "-fstack-protector-all" { target fstack_protector } } */
void
bar (void);
void
foo (int x)
{
if (x)
bar ();
}