error.c (gfc_diagnostic_build_locus_prefix): Use diagnostic_expand_location.
gcc/fortran/ChangeLog: 2014-12-05 Manuel López-Ibáñez <manu@gcc.gnu.org> * error.c (gfc_diagnostic_build_locus_prefix): Use diagnostic_expand_location. gcc/ChangeLog: 2014-12-05 Manuel López-Ibáñez <manu@gcc.gnu.org> * diagnostic.h (diagnostic_expand_location): New inline function. * diagnostic.c (diagnostic_build_prefix): Use it. (diagnostic_show_locus): Likewise. From-SVN: r218409
This commit is contained in:
parent
1be7144689
commit
99abe958d8
|
@ -1,3 +1,9 @@
|
|||
2014-12-05 Manuel López-Ibáñez <manu@gcc.gnu.org>
|
||||
|
||||
* diagnostic.h (diagnostic_expand_location): New inline function.
|
||||
* diagnostic.c (diagnostic_build_prefix): Use it.
|
||||
(diagnostic_show_locus): Likewise.
|
||||
|
||||
2014-12-04 H.J. Lu <hongjiu.lu@intel.com>
|
||||
|
||||
PR bootstrap/64189
|
||||
|
|
|
@ -260,6 +260,8 @@ diagnostic_build_prefix (diagnostic_context *context,
|
|||
#undef DEFINE_DIAGNOSTIC_KIND
|
||||
NULL
|
||||
};
|
||||
gcc_assert (diagnostic->kind < DK_LAST_DIAGNOSTIC_KIND);
|
||||
|
||||
const char *text = _(diagnostic_kind_text[diagnostic->kind]);
|
||||
const char *text_cs = "", *text_ce = "";
|
||||
const char *locus_cs, *locus_ce;
|
||||
|
@ -274,11 +276,7 @@ diagnostic_build_prefix (diagnostic_context *context,
|
|||
locus_cs = colorize_start (pp_show_color (pp), "locus");
|
||||
locus_ce = colorize_stop (pp_show_color (pp));
|
||||
|
||||
expanded_location s = expand_location_to_spelling_point (diagnostic->location);
|
||||
if (diagnostic->override_column)
|
||||
s.column = diagnostic->override_column;
|
||||
gcc_assert (diagnostic->kind < DK_LAST_DIAGNOSTIC_KIND);
|
||||
|
||||
expanded_location s = diagnostic_expand_location (diagnostic);
|
||||
return
|
||||
(s.file == NULL
|
||||
? build_message_string ("%s%s:%s %s%s%s", locus_cs, progname, locus_ce,
|
||||
|
@ -289,8 +287,8 @@ diagnostic_build_prefix (diagnostic_context *context,
|
|||
: context->show_column
|
||||
? build_message_string ("%s%s:%d:%d:%s %s%s%s", locus_cs, s.file, s.line,
|
||||
s.column, locus_ce, text_cs, text, text_ce)
|
||||
: build_message_string ("%s%s:%d:%s %s%s%s", locus_cs, s.file, s.line, locus_ce,
|
||||
text_cs, text, text_ce));
|
||||
: build_message_string ("%s%s:%d:%s %s%s%s", locus_cs, s.file, s.line,
|
||||
locus_ce, text_cs, text, text_ce));
|
||||
}
|
||||
|
||||
/* If LINE is longer than MAX_WIDTH, and COLUMN is not smaller than
|
||||
|
@ -337,9 +335,7 @@ diagnostic_show_locus (diagnostic_context * context,
|
|||
return;
|
||||
|
||||
context->last_location = diagnostic->location;
|
||||
s = expand_location_to_spelling_point (diagnostic->location);
|
||||
if (diagnostic->override_column)
|
||||
s.column = diagnostic->override_column;
|
||||
s = diagnostic_expand_location (diagnostic);
|
||||
line = location_get_source_line (s, &line_width);
|
||||
if (line == NULL || s.column > line_width)
|
||||
return;
|
||||
|
|
|
@ -297,6 +297,18 @@ void diagnostic_set_caret_max_width (diagnostic_context *context, int value);
|
|||
|
||||
void diagnostic_file_cache_fini (void);
|
||||
|
||||
/* Expand the location of this diagnostic. Use this function for consistency. */
|
||||
|
||||
static inline expanded_location
|
||||
diagnostic_expand_location (const diagnostic_info * diagnostic)
|
||||
{
|
||||
expanded_location s
|
||||
= expand_location_to_spelling_point (diagnostic->location);
|
||||
if (diagnostic->override_column)
|
||||
s.column = diagnostic->override_column;
|
||||
return s;
|
||||
}
|
||||
|
||||
/* Pure text formatting support functions. */
|
||||
extern char *file_name_as_prefix (diagnostic_context *, const char *);
|
||||
|
||||
|
|
|
@ -1,3 +1,8 @@
|
|||
2014-12-05 Manuel López-Ibáñez <manu@gcc.gnu.org>
|
||||
|
||||
* error.c (gfc_diagnostic_build_locus_prefix): Use
|
||||
diagnostic_expand_location.
|
||||
|
||||
2014-12-05 Manuel López-Ibáñez <manu@gcc.gnu.org>
|
||||
|
||||
* scanner.c (gfc_next_char_literal): Use gfc_warning_now.
|
||||
|
|
|
@ -1143,10 +1143,7 @@ gfc_diagnostic_build_locus_prefix (diagnostic_context *context,
|
|||
pretty_printer *pp = context->printer;
|
||||
const char *locus_cs = colorize_start (pp_show_color (pp), "locus");
|
||||
const char *locus_ce = colorize_stop (pp_show_color (pp));
|
||||
expanded_location s = expand_location_to_spelling_point (diagnostic->location);
|
||||
if (diagnostic->override_column)
|
||||
s.column = diagnostic->override_column;
|
||||
|
||||
expanded_location s = diagnostic_expand_location (diagnostic);
|
||||
return (s.file == NULL
|
||||
? build_message_string ("%s%s:%s", locus_cs, progname, locus_ce )
|
||||
: !strcmp (s.file, N_("<built-in>"))
|
||||
|
|
Loading…
Reference in New Issue