OpenE2K/gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

PR middle-end/89934 - ICE on a call with fewer arguments to strncpy declared without prototype

Browse Source 
gcc/ChangeLog:

	PR middle-end/89934
	* gimple-ssa-warn-restrict.c (builtin_access::builtin_access): Bail
	out if the number of arguments is less than expected.

gcc/testsuite/ChangeLog:

	PR middle-end/89934
	* gcc.dg/Wrestrict-19.c: New test.
	* gcc.dg/Wrestrict-5.c: Add comment.  Remove unused code.

From-SVN: r270152
This commit is contained in:
Martin Sebor 2019-04-04 21:59:49 +00:00 committed by Martin Sebor
parent c2457887ea
commit 9a0cbb60d2
5 changed files with 51 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gcc/ChangeLog
View File

@ -1,3 +1,9 @@
2019-04-04 Martin Sebor <msebor@redhat.com>
PR middle-end/89934
* gimple-ssa-warn-restrict.c (builtin_access::builtin_access): Bail
out if the number of arguments is less than expected.
2019-04-04 Jeff Law <law@redhat.com>
PR rtl-optimization/89399

4
gcc/gimple-ssa-warn-restrict.c
View File

@ -730,6 +730,10 @@ builtin_access::builtin_access (gimple *call, builtin_memref &dst,
offset_int bounds[2] = { maxobjsize, maxobjsize };
if (dstref->strbounded_p)
{
unsigned nargs = gimple_call_num_args (call);
if (nargs <= sizeargno)
return;
tree size = gimple_call_arg (call, sizeargno);
tree range[2];
if (get_size_range (size, range, true))

6
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,9 @@
2019-04-04 Martin Sebor <msebor@redhat.com>
PR middle-end/89934
* gcc.dg/Wrestrict-19.c: New test.
* gcc.dg/Wrestrict-5.c: Add comment. Remove unused code.
2019-04-04 Jeff Law <law@redhat.com>
PR rtl-optimization/89399

32
gcc/testsuite/gcc.dg/Wrestrict-19.c Normal file
View File

@ -0,0 +1,32 @@
/* PR middle-end/89934 - ICE on a call with fewer arguments to strncpy
declared without prototype
{ dg-do compile }
{ dg-options "-O2 -Wall" } */
typedef __SIZE_TYPE__ size_t;
char *strncpy ();
char* f0 (char *s)
{
return strncpy ();
}
char* f1 (char *s)
{
return strncpy (s);
}
char* f2 (char *s)
{
return strncpy (s, s + 1); /* ICE here. */
}
void f3 (char *s, size_t n, const char *t)
{
strncpy (s, n, t);
strncpy (n, s, t);
}
/* { dg-prune-output "\\\[-Wbuiltin-declaration-mismatch]" }
{ dg-prune-output "\\\[-Wint-conversion]" } */

15
gcc/testsuite/gcc.dg/Wrestrict-5.c
View File

@ -1,20 +1,11 @@
/* Test to verify that valid calls to common restrict-qualified built-in
/* PR tree-optimization/83655 - ICE on an invalid call to memcpy declared
with no prototype
Test to verify that valid calls to common restrict-qualified built-in
functions declared with no prototype are checked for overlap, and that
invalid calls are ignored.
{ dg-do compile }
{ dg-prune-output "conflicting types for built-in" }
{ dg-options "-O2 -Wrestrict" } */
typedef __SIZE_TYPE__ size_t;
#if __cplusplus
extern "C" {
#define NO_PROTO ...
#else
#define NO_PROTO /* empty */
#endif
void* memcpy ();
char* strncpy ();