middle-end/104492 - avoid all equality compare dangling pointer diags
The following extends the equality compare dangling pointer diagnostics suppression for uses following free or realloc to also cover those following invalidation of auto variables via CLOBBERs. That avoids diagnosing idioms like return std::find(std::begin(candidates), std::end(candidates), s) != std::end(candidates); for auto candidates which are prone to forwarding of the final comparison across the storage invalidation as then seen by the late run access warning pass. 2022-04-25 Richard Biener <rguenther@suse.de> PR middle-end/104492 * gimple-ssa-warn-access.cc (pass_waccess::warn_invalid_pointer): Exclude equality compare diagnostics for all kind of invalidations. (pass_waccess::check_dangling_uses): Fix post-dominator query. (pass_waccess::check_pointer_uses): Likewise.
This commit is contained in:
parent
6a460a2007
commit
9aaaae7edb
|
@ -3923,7 +3923,8 @@ pass_waccess::warn_invalid_pointer (tree ref, gimple *use_stmt,
|
|||
return;
|
||||
}
|
||||
|
||||
if ((maybe && warn_dangling_pointer < 2)
|
||||
if (equality
|
||||
|| (maybe && warn_dangling_pointer < 2)
|
||||
|| warning_suppressed_p (use_stmt, OPT_Wdangling_pointer_))
|
||||
return;
|
||||
|
||||
|
@ -4241,7 +4242,7 @@ pass_waccess::check_pointer_uses (gimple *stmt, tree ptr,
|
|||
basic_block use_bb = gimple_bb (use_stmt);
|
||||
bool this_maybe
|
||||
= (maybe
|
||||
|| !dominated_by_p (CDI_POST_DOMINATORS, use_bb, stmt_bb));
|
||||
|| !dominated_by_p (CDI_POST_DOMINATORS, stmt_bb, use_bb));
|
||||
warn_invalid_pointer (*use_p->use, use_stmt, stmt, var,
|
||||
this_maybe, equality);
|
||||
continue;
|
||||
|
@ -4486,7 +4487,7 @@ pass_waccess::check_dangling_uses (tree var, tree decl, bool maybe /* = false */
|
|||
|
||||
basic_block use_bb = gimple_bb (use_stmt);
|
||||
basic_block clob_bb = gimple_bb (*pclob);
|
||||
maybe = maybe || !dominated_by_p (CDI_POST_DOMINATORS, use_bb, clob_bb);
|
||||
maybe = maybe || !dominated_by_p (CDI_POST_DOMINATORS, clob_bb, use_bb);
|
||||
warn_invalid_pointer (var, use_stmt, *pclob, decl, maybe, false);
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in New Issue