OpenE2K/gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

ServerSocket.java (accept): Remove bogus security check.

Browse Source 
2006-01-14  Anthony Green  <green@redhat.com>

        * java/net/ServerSocket.java (accept): Remove bogus
        security check.
	(implAccept): Add FIXME comment.

From-SVN: r109719
This commit is contained in:
Anthony Green 2006-01-15 03:00:21 +00:00 committed by Anthony Green
parent 5d1dcaa2c3
commit 9b36eaf68e
2 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
libjava/classpath/ChangeLog
View File

@ -1,3 +1,9 @@
2006-01-14 Anthony Green <green@redhat.com>
* java/net/ServerSocket.java (accept): Remove bogus
security check.
(implAccept): Add FIXME comment.
2005-12-27 Tom Tromey <tromey@redhat.com> 2005-12-27 Tom Tromey <tromey@redhat.com>
* gnu/java/nio/SelectorImpl.java: Added import. * gnu/java/nio/SelectorImpl.java: Added import.

8
libjava/classpath/java/net/ServerSocket.java
View File

@ -314,11 +314,6 @@ public class ServerSocket
*/ */
public Socket accept() throws IOException public Socket accept() throws IOException
{ {
SecurityManager sm = System.getSecurityManager();
if (sm != null)
sm.checkAccept(impl.getInetAddress().getHostAddress(),
impl.getLocalPort());
Socket socket = new Socket(); Socket socket = new Socket();
try try
@ -360,6 +355,9 @@ public class ServerSocket
if (isClosed()) if (isClosed())
throw new SocketException("ServerSocket is closed"); throw new SocketException("ServerSocket is closed");
// FIXME: Add a security check to make sure we're allowed to
// connect to the remote host.
// The Sun spec says that if we have an associated channel and // The Sun spec says that if we have an associated channel and
// it is in non-blocking mode, we throw an IllegalBlockingModeException. // it is in non-blocking mode, we throw an IllegalBlockingModeException.
// However, in our implementation if the channel itself initiated this // However, in our implementation if the channel itself initiated this