OpenE2K/gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

assert instead of silently failing code gen

Browse Source 
* graphite-isl-ast-to-gimple.c (get_rename_from_scev): Assert instead of
	setting codegen_error to fail codegen.

From-SVN: r232932
This commit is contained in:
Sebastian Pop 2016-01-28 16:38:52 +00:00 committed by Sebastian Pop
parent 9925bb881f
commit 9b496f67e7
2 changed files with 11 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gcc/ChangeLog
View File

@ -1,3 +1,8 @@
2016-01-28 Sebastian Pop <s.pop@samsung.com>
* graphite-isl-ast-to-gimple.c (get_rename_from_scev): Assert instead of
setting codegen_error to fail codegen.
2016-01-28 Jason Merrill <jason@redhat.com> 2016-01-28 Jason Merrill <jason@redhat.com>
* tree.h (BINFO_FLAG_0): Rename from BINFO_MARKED. * tree.h (BINFO_FLAG_0): Rename from BINFO_MARKED.

26
gcc/graphite-isl-ast-to-gimple.c
View File

@ -1833,31 +1833,18 @@ get_rename_from_scev (tree old_name, gimple_seq *stmts, loop_p loop,
tree scev = scalar_evolution_in_region (region->region, loop, old_name); tree scev = scalar_evolution_in_region (region->region, loop, old_name);
/* At this point we should know the exact scev for each /* At this point we should know the exact scev for each
scalar SSA_NAME used in the scop: all the other scalar scalar SSA_NAME used in the scop. */
SSA_NAMEs should have been translated out of SSA using gcc_assert (!chrec_contains_undetermined (scev));
arrays with one element. */
tree new_expr;
if (chrec_contains_undetermined (scev))
{
codegen_error = true;
return build_zero_cst (TREE_TYPE (old_name));
}
new_expr = chrec_apply_map (scev, iv_map); tree new_expr = chrec_apply_map (scev, iv_map);
/* The apply should produce an expression tree containing /* The apply should produce an expression tree containing
the uses of the new induction variables. We should be the uses of the new induction variables. We should be
able to use new_expr instead of the old_name in the newly able to use new_expr instead of the old_name in the newly
generated loop nest. */ generated loop nest. */
if (chrec_contains_undetermined (new_expr) gcc_assert (!chrec_contains_undetermined (new_expr)
|| tree_contains_chrecs (new_expr, NULL)) && !tree_contains_chrecs (new_expr, NULL));
{
codegen_error = true;
return build_zero_cst (TREE_TYPE (old_name));
}
/* We should check all the operands and all of them should dominate the use at
new_expr. */
if (TREE_CODE (new_expr) == SSA_NAME) if (TREE_CODE (new_expr) == SSA_NAME)
{ {
basic_block bb = gimple_bb (SSA_NAME_DEF_STMT (new_expr)); basic_block bb = gimple_bb (SSA_NAME_DEF_STMT (new_expr));
@ -1898,8 +1885,7 @@ get_rename_from_scev (tree old_name, gimple_seq *stmts, loop_p loop,
substitution map RENAME_MAP, inserting the gimplification code at substitution map RENAME_MAP, inserting the gimplification code at
GSI_TGT, for the translation REGION, with the original copied GSI_TGT, for the translation REGION, with the original copied
statement in LOOP, and using the induction variable renaming map statement in LOOP, and using the induction variable renaming map
IV_MAP. Returns true when something has been renamed. codegen_error IV_MAP. Returns true when something has been renamed. */
is set when the code generation cannot continue. */
bool bool
translate_isl_ast_to_gimple::rename_uses (gimple *copy, translate_isl_ast_to_gimple::rename_uses (gimple *copy,