OpenE2K/gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix bug in constraint-check generator, reported by Rask Ingemann Lambertsen:

Browse Source 
Fix bug in constraint-check generator, reported by Rask Ingemann
	Lambertsen:
	* genpreds.c (add_constraint): Don't remove anything from the
	expression here.
	(write_tm_constrs_h): Detect whether "op" argument is used, and
	mark it ARG_UNUSED if it isn't.
	(write_insn_const_int_ok_for_constraint): Skip the part of the
	expression that would test whether "op" (which is not available
	here) is a CONST_INT.

From-SVN: r117433
This commit is contained in:
Zack Weinberg 2006-10-04 16:41:55 +00:00
parent 2e38371e01
commit 9e8265851d
2 changed files with 25 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
gcc/ChangeLog
View File

@ -1,3 +1,15 @@
2006-10-04 Zack Weinberg <zackw@panix.com>
Fix bug in constraint-check generator, reported by Rask Ingemann
Lambertsen:
* genpreds.c (add_constraint): Don't remove anything from the
expression here.
(write_tm_constrs_h): Detect whether "op" argument is used, and
mark it ARG_UNUSED if it isn't.
(write_insn_const_int_ok_for_constraint): Skip the part of the
expression that would test whether "op" (which is not available
here) is a CONST_INT.
2006-10-04 Ryan Mansfield <rmansfield@qnx.com>
PR c++/28448

16
gcc/genpreds.c
View File

@ -891,10 +891,6 @@ add_constraint (const char *name, const char *regclass,
have_error = 1;
return;
}
/* Remove the redundant (and (match_code "const_(int|double)")
from the expression. */
exp = XEXP (exp, 1);
}
@ -1078,10 +1074,13 @@ write_tm_constrs_h (void)
bool needs_rval = needs_variable (c->exp, "rval");
bool needs_mode = (needs_variable (c->exp, "mode")
|| needs_hval || needs_lval || needs_rval);
bool needs_op = (needs_variable (c->exp, "op")
|| needs_ival || needs_mode);
printf ("static inline bool\n"
"satisfies_constraint_%s (rtx op)\n"
"{\n", c->c_name);
"satisfies_constraint_%s (rtx %s)\n"
"{\n", c->c_name,
needs_op ? "op" : "ARG_UNUSED (op)");
if (needs_mode)
puts ("enum machine_mode mode = GET_MODE (op);");
if (needs_ival)
@ -1157,7 +1156,10 @@ write_insn_const_int_ok_for_constraint (void)
if (c->is_const_int)
{
printf (" case CONSTRAINT_%s:\n return ", c->c_name);
write_predicate_expr (c->exp);
/* c->exp is guaranteed to be (and (match_code "const_int") (...));
we know at this point that we have a const_int, so we need not
bother with that part of the test. */
write_predicate_expr (XEXP (c->exp, 1));
fputs (";\n\n", stdout);
}