OpenE2K/gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

re PR go/47378 (ld warning linking with libgo.so: relocation bound to a symbol with STV_PROTECTED visibility)

Browse Source 
PR go/47378
Don't use protected visibility for type descriptors.

From-SVN: r169946
This commit is contained in:
Ian Lance Taylor 2011-02-08 20:55:02 +00:00
parent 76eddcf660
commit a0e1520784
1 changed files with 6 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
gcc/go/gofrontend/gogo-tree.cc
View File

@ -2633,25 +2633,13 @@ Gogo::build_type_descriptor_decl(const Type* type, Expression* initializer,
DECL_INITIAL(decl) = constructor;
if (type_descriptor_location == TYPE_DESCRIPTOR_COMMON)
{
make_decl_one_only(decl, DECL_ASSEMBLER_NAME(decl));
resolve_unique_section(decl, 1, 0);
}
if (type_descriptor_location == TYPE_DESCRIPTOR_DEFINED)
TREE_PUBLIC(decl) = 1;
else
{
#ifdef OBJECT_FORMAT_ELF
// Give the decl protected visibility. This avoids out-of-range
// references with shared libraries with the x86_64 small model
// when the type descriptor gets a COPY reloc into the main
// executable. There is no need to have unique pointers to type
// descriptors, as the runtime code compares reflection strings
// if necessary.
DECL_VISIBILITY(decl) = VISIBILITY_PROTECTED;
DECL_VISIBILITY_SPECIFIED(decl) = 1;
#endif
TREE_PUBLIC(decl) = 1;
gcc_assert(type_descriptor_location == TYPE_DESCRIPTOR_COMMON);
make_decl_one_only(decl, DECL_ASSEMBLER_NAME(decl));
resolve_unique_section(decl, 1, 0);
}
rest_of_decl_compilation(decl, 1, 0);
@ -2764,17 +2752,7 @@ Gogo::interface_method_table_for_type(const Interface_type* interface,
// definition of the table. Otherwise it is a comdat table which
// may be defined in multiple packages.
if (has_hidden_methods)
{
#ifdef OBJECT_FORMAT_ELF
// Give the decl protected visibility. This avoids out-of-range
// references with shared libraries with the x86_64 small model
// when the table gets a COPY reloc into the main executable.
DECL_VISIBILITY(decl) = VISIBILITY_PROTECTED;
DECL_VISIBILITY_SPECIFIED(decl) = 1;
#endif
TREE_PUBLIC(decl) = 1;
}
TREE_PUBLIC(decl) = 1;
else
{
make_decl_one_only(decl, DECL_ASSEMBLER_NAME(decl));