OpenE2K
/
gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

arm: fix rtl checking bootstrap (PR target/93312) 

As reported in PR93312, the:
> > > > > >         * config/arm/arm.c (clear_operation_p): New function.
change broke RTL checking bootstrap.

On the testcase from the PR (which is distilled from libgcc2.c, so I think
we don't need to add it into testsuite) we ICE because SET_DEST (elt) is
not a REG, but SUBREG.  The code uses REGNO on it, which is invalid, but
only stores it into a variable, then performs REG_P (reg) check,
determines it is not a REG and bails early.

The following patch just moves the regno variable initialization after that
check, it isn't used in between.  And, as a small optimization, because
reg doesn't change, doesn't use REGNO (reg) a second time to set last_regno.

2020-01-18  Jakub Jelinek  <jakub@redhat.com>

	PR target/93312
	* config/arm/arm.c (clear_operation_p): Don't use REGNO until
	after checking the argument is a REG.  Don't use REGNO (reg)
	again to set last_regno, reuse regno variable instead.
This commit is contained in:
Jakub Jelinek 2020-01-18 09:41:59 +01:00
parent e2947cfa2d
commit a22a86a18b
2 changed files with 15 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gcc/ChangeLog
View File

@ -1,3 +1,10 @@
2020-01-18 Jakub Jelinek <jakub@redhat.com>
PR target/93312
* config/arm/arm.c (clear_operation_p): Don't use REGNO until
after checking the argument is a REG. Don't use REGNO (reg)
again to set last_regno, reuse regno variable instead.
2020-01-17 David Malcolm <dmalcolm@redhat.com>
* doc/analyzer.texi (Limitations): Add note about NaN.

5
gcc/config/arm/arm.c
View File

@ -13779,7 +13779,6 @@ clear_operation_p (rtx op, bool vfp)
return false;
reg = SET_DEST (elt);
regno = REGNO (reg);
zero = SET_SRC (elt);
if (!REG_P (reg)
@ -13787,6 +13786,8 @@ clear_operation_p (rtx op, bool vfp)
|| zero != CONST0_RTX (SImode))
return false;
regno = REGNO (reg);
if (vfp)
{
if (i != 1 && regno != last_regno + 1)
@ -13800,7 +13801,7 @@ clear_operation_p (rtx op, bool vfp)
return false;
}
last_regno = REGNO (reg);
last_regno = regno;
}
return true;