OpenE2K
/
gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

compiler: stop iterator on error 

If there is an error reading or parsing an archive header, the
    Archive_iterator code would return a dummy header but would not mark
    itself as done.  The effect is that an invalid archive leads to an
    endless loop reading and re-reading the same archive header.  Avoid
    that by setting the offset to the end of the file, which will cause
    the iterator to == archive_end.
    
    No test since it doesn't seem worth constructing an invalid archive.
    
    Reviewed-on: https://go-review.googlesource.com/c/158217

From-SVN: r268129
This commit is contained in:
Ian Lance Taylor 2019-01-21 22:58:04 +00:00
parent 44f4e4182b
commit a9647bf912
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gcc/go/gofrontend/MERGE
View File

@ -1,4 +1,4 @@
c76ba3014e42cc6adc3d43709bba28c5ad7a6ba2 e7427654f3af83e1feea727a62a97172d7721403
The first line of this file holds the git revision number of the last The first line of this file holds the git revision number of the last
merge done from the gofrontend repository. merge done from the gofrontend repository.

1
gcc/go/gofrontend/import-archive.cc
View File

@ -780,6 +780,7 @@ Archive_iterator::read_next_header()
&this->next_off_)) &this->next_off_))
{ {
this->header_.off = filesize; this->header_.off = filesize;
this->off_ = filesize;
return; return;
} }
this->header_.off = this->off_; this->header_.off = this->off_;