OpenE2K/gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

re PR c++/62232 (-Wnon-virtual-dtor shouldn't warn on final classes)

Browse Source 
/cp
2014-09-18  Paolo Carlini  <paolo.carlini@oracle.com>

	PR c++/62232
	* class.c (finish_struct_1): Do not -Wnon-virtual-dtor warn
	for final class types.

/testsuite
2014-09-18  Paolo Carlini  <paolo.carlini@oracle.com>

	PR c++/62232
	* g++.dg/cpp0x/Wdtor1.C: New.

From-SVN: r215351
This commit is contained in:
Paolo Carlini 2014-09-18 13:48:33 +00:00 committed by Paolo Carlini
parent 4666e1fb92
commit abce92087b
4 changed files with 26 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gcc/cp/ChangeLog
View File

@ -1,3 +1,9 @@
2014-09-18 Paolo Carlini <paolo.carlini@oracle.com>
PR c++/62232
* class.c (finish_struct_1): Do not -Wnon-virtual-dtor warn
for final class types.
2014-09-15 Jason Merrill <jason@redhat.com> 2014-09-15 Jason Merrill <jason@redhat.com>
* pt.c (lookup_template_class_1): Splice out abi_tag attribute if * pt.c (lookup_template_class_1): Splice out abi_tag attribute if

3
gcc/cp/class.c
View File

@ -6506,7 +6506,8 @@ finish_struct_1 (tree t)
/* This warning does not make sense for Java classes, since they /* This warning does not make sense for Java classes, since they
cannot have destructors. */ cannot have destructors. */
if (!TYPE_FOR_JAVA (t) && warn_nonvdtor if (!TYPE_FOR_JAVA (t) && warn_nonvdtor
&& TYPE_POLYMORPHIC_P (t) && accessible_nvdtor_p (t)) && TYPE_POLYMORPHIC_P (t) && accessible_nvdtor_p (t)
&& !CLASSTYPE_FINAL (t))
warning (OPT_Wnon_virtual_dtor, warning (OPT_Wnon_virtual_dtor,
"%q#T has virtual functions and accessible" "%q#T has virtual functions and accessible"
" non-virtual destructor", t); " non-virtual destructor", t);

5
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2014-09-18 Paolo Carlini <paolo.carlini@oracle.com>
PR c++/62232
* g++.dg/cpp0x/Wdtor1.C: New.
2014-09-18 Joseph Myers <joseph@codesourcery.com> 2014-09-18 Joseph Myers <joseph@codesourcery.com>
* gcc.dg/torture/float128-exact-underflow.c: New test. * gcc.dg/torture/float128-exact-underflow.c: New test.

13
gcc/testsuite/g++.dg/cpp0x/Wdtor1.C Normal file
View File

@ -0,0 +1,13 @@
// PR c++/62232
// { dg-do compile { target c++11 } }
// { dg-options "-Wnon-virtual-dtor" }
class base
{
protected:
~base () {}
virtual void foo (){};
};
class derive final : public base
{
};