OpenE2K
/
gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

c-typeck.c (build_conditional_expr): Do not allow non-lvalue arrays. 

* c-typeck.c (build_conditional_expr): Do not allow non-lvalue
	arrays.

testsuite:
	* gcc.dg/c90-array-lval-7.c, gcc.dg/c99-array-lval-7.c: New tests.

From-SVN: r76477
This commit is contained in:
Joseph Myers 2004-01-24 00:30:58 +00:00 committed by Joseph Myers
parent 251804e635
commit b1adf557d8
5 changed files with 61 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gcc/ChangeLog
View File

@ -1,3 +1,8 @@
2004-01-24 Joseph S. Myers <jsm@polyomino.org.uk>
* c-typeck.c (build_conditional_expr): Do not allow non-lvalue
arrays.
2004-01-23 Kazu Hirata <kazu@cs.umass.edu>
* recog.c: Fix a typo in copyright.

8
gcc/c-typeck.c
View File

@ -2651,6 +2651,14 @@ build_conditional_expr (tree ifexp, tree op1, tree op2)
type2 = TREE_TYPE (op2);
code2 = TREE_CODE (type2);
/* C90 does not permit non-lvalue arrays in conditional expressions.
In C99 they will be pointers by now. */
if (code1 == ARRAY_TYPE || code2 == ARRAY_TYPE)
{
error ("non-lvalue array in conditional expression");
return error_mark_node;
}
/* Quickly detect the usual case where op1 and op2 have the same type
after promotion. */
if (TYPE_MAIN_VARIANT (type1) == TYPE_MAIN_VARIANT (type2))

4
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,7 @@
2004-01-24 Joseph S. Myers <jsm@polyomino.org.uk>
* gcc.dg/c90-array-lval-7.c, gcc.dg/c99-array-lval-7.c: New tests.
2004-01-23 Andrew Pinski <apinski@apple.com>
* gcc.dg/20030121-1.c: Move to ..

23
gcc/testsuite/gcc.dg/c90-array-lval-7.c Normal file
View File

@ -0,0 +1,23 @@
/* Test for non-lvalue arrays: test that C90 does not allow them in
conditional expressions, while in C99 they decay and are
allowed. */
/* Origin: Joseph Myers <jsm@polyomino.org.uk> */
/* { dg-do compile } */
/* { dg-options "-std=iso9899:1990 -pedantic-errors" } */
struct s { char c[1]; };
struct s a, b, c;
int d;
int e;
void
bar (void)
{
/* In C90, the non-lvalue arrays do not decay to pointers, and
6.3.15 does not permit conditional expressions between arrays.
In C99, they decay to pointers. */
(e ? (d ? b : c).c : (e ? b : c).c); /* { dg-bogus "warning" "warning in place of error" } */
}
/* { dg-error "array" "bad conditional" { target *-*-* } 20 } */

21
gcc/testsuite/gcc.dg/c99-array-lval-7.c Normal file
View File

@ -0,0 +1,21 @@
/* Test for non-lvalue arrays: test that C90 does not allow them in
conditional expressions, while in C99 they decay and are
allowed. */
/* Origin: Joseph Myers <jsm@polyomino.org.uk> */
/* { dg-do compile } */
/* { dg-options "-std=iso9899:1999 -pedantic-errors" } */
struct s { char c[1]; };
struct s a, b, c;
int d;
int e;
void
bar (void)
{
/* In C90, the non-lvalue arrays do not decay to pointers, and
6.3.15 does not permit conditional expressions between arrays.
In C99, they decay to pointers. */
(e ? (d ? b : c).c : (e ? b : c).c);
}