OpenE2K/gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

match.pd: Don't optimize vector X + (X << C) -> X * (1 + (1 << C)) if there is no mult support [PR99544]

Browse Source 
E.g. on aarch64, the target has V2DImode addition and shift by scalar
optabs, but doesn't have V2DImode multiply.  The following testcase
ICEs because this simplification is done after last lowering, but
generally, even if it is done before that, turning it into a multiplication
will not be an improvement because that means scalarization, while the former
can be done in vectors.

It would be nice if we added expansion support for vector multiplication
by uniform constants using shifts and additions like we have for scalar
multiplication, but that is something that can be done in stage1.

2021-03-13  Jakub Jelinek  <jakub@redhat.com>

	PR tree-optimization/99544
	* match.pd (X + (X << C) -> X * (1 + (1 << C))): Don't simplify
	if for vector types multiplication can't be done in type's mode.

	* gcc.dg/gomp/pr99544.c: New test.
This commit is contained in:
Jakub Jelinek 2021-03-13 08:56:15 +01:00
parent 3972574f11
commit bbdf59fdbc
2 changed files with 21 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
gcc/match.pd
View File

@ -2788,7 +2788,10 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT)
(plus:c @0 (lshift:s @0 INTEGER_CST@1))
(if (ANY_INTEGRAL_TYPE_P (TREE_TYPE (@0))
&& tree_fits_uhwi_p (@1)
&& tree_to_uhwi (@1) < element_precision (type))
&& tree_to_uhwi (@1) < element_precision (type)
&& (INTEGRAL_TYPE_P (TREE_TYPE (@0))
|| optab_handler (smul_optab,
TYPE_MODE (type)) != CODE_FOR_nothing))
(with { tree t = type;
if (!TYPE_OVERFLOW_WRAPS (t)) t = unsigned_type_for (t);
wide_int w = wi::set_bit_in_zero (tree_to_uhwi (@1),
@ -2804,7 +2807,10 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT)
&& tree_fits_uhwi_p (@1)
&& tree_to_uhwi (@1) < element_precision (type)
&& tree_fits_uhwi_p (@2)
&& tree_to_uhwi (@2) < element_precision (type))
&& tree_to_uhwi (@2) < element_precision (type)
&& (INTEGRAL_TYPE_P (TREE_TYPE (@0))
|| optab_handler (smul_optab,
TYPE_MODE (type)) != CODE_FOR_nothing))
(with { tree t = type;
if (!TYPE_OVERFLOW_WRAPS (t)) t = unsigned_type_for (t);
unsigned int prec = element_precision (type);

13
gcc/testsuite/gcc.dg/gomp/pr99544.c Normal file
View File

@ -0,0 +1,13 @@
/* PR tree-optimization/99544 */
/* { dg-do compile } */
/* { dg-options "-Os -fopenmp" } */
long
foo (long a, long b, long c)
{
long d, e;
#pragma omp teams distribute parallel for simd firstprivate (a, b, c) lastprivate(e)
for (d = a; d < b; d++)
e = c + d * 5;
return e;
}