OpenE2K/gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

re PR c++/17120 (warning: suggest parentheses around assignment used as truth value)

Browse Source 
cp:
	PR c++/17120
	* pt.c (tsubst_copy_and_build): Avoid clearing TREE_NO_WARNING for
	MODOP_EXPR.

testsuite:
	* g++.dg/warn/Wparentheses-4.C: New test.

From-SVN: r86351
This commit is contained in:
Joseph Myers 2004-08-21 01:19:17 +01:00 committed by Joseph Myers
parent 596cfbb6c0
commit bcf9a914ff
4 changed files with 38 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gcc/cp/ChangeLog
View File

@ -1,3 +1,9 @@
2004-08-21 Joseph S. Myers <jsm@polyomino.org.uk>
PR c++/17120
* pt.c (tsubst_copy_and_build): Avoid clearing TREE_NO_WARNING for
MODOP_EXPR.
2004-08-20 Kriang Lerdsuwanakij <lerdsuwa@users.sourceforge.net>
* pt.c (register_specialization): Check DECL_TEMPLATE_SPECIALIZATION

9
gcc/cp/pt.c
View File

@ -8353,7 +8353,14 @@ tsubst_copy_and_build (tree t,
(RECUR (TREE_OPERAND (t, 0)),
TREE_CODE (TREE_OPERAND (t, 1)),
RECUR (TREE_OPERAND (t, 2)));
TREE_NO_WARNING (r) = TREE_NO_WARNING (t);
/* TREE_NO_WARNING must be set if either the expression was
parenthesized or it uses an operator such as >>= rather
than plain assignment. In the former case, it was already
set and must be copied. In the latter case,
build_x_modify_expr sets it and it must not be reset
here. */
if (TREE_NO_WARNING (t))
TREE_NO_WARNING (r) = TREE_NO_WARNING (t);
return r;
}

5
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2004-08-21 Joseph S. Myers <jsm@polyomino.org.uk>
PR c++/17120
* g++.dg/warn/Wparentheses-4.C: New test.
2004-08-20 Mark Mitchell <mark@codesourcery.com>
* gcc.dg/darwin-longlong.c: Include <stdlib.h>.

19
gcc/testsuite/g++.dg/warn/Wparentheses-4.C Normal file
View File

@ -0,0 +1,19 @@
// Test that -Wparentheses does not give bogus warnings in the
// presence of templates for non-plain assignment. Bug 17120.
// { dg-do compile }
// { dg-options "-Wparentheses" }
template<typename _Tp>
inline _Tp
cmath_power(_Tp __x, unsigned int __n)
{
while (__n >>= 1)
;
return __x;
}
int main()
{
cmath_power(1.0, 3);
}