OpenE2K/gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

aarch64: fix strict alignment for vector load/stores (PR 91927)

Browse Source 
Hi,
  The problem here is that the vector mode version of movmisalign<mode>
was only conditionalized on if SIMD was enabled instead of being
also conditionalized on STRICT_ALIGNMENT too.

Applied as pre-approved in the bug report by Richard Sandiford
after a bootstrap/test on aarch64-linux-gnu.

Thanks,
Andrew Pinski

ChangeLog:
PR target/91927
* config/aarch64/aarch64-simd.md (movmisalign<mode>): Check
STRICT_ALIGNMENT also.

testsuite/ChangeLog:
PR target/91927
* gcc.target/aarch64/pr91927.c: New testcase.
This commit is contained in:
Andrew Pinski 2020-02-08 15:57:54 +00:00
parent 4b39d801b2
commit c2a4bf2d6e
4 changed files with 50 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gcc/ChangeLog
View File

@ -1,3 +1,9 @@
2020-02-08 Andrew Pinski <apinski@marvell.com>
PR target/91927
* config/aarch64/aarch64-simd.md (movmisalign<mode>): Check
STRICT_ALIGNMENT also.
2020-02-08 Jim Wilson <jimw@sifive.com>
PR target/93532

2
gcc/config/aarch64/aarch64-simd.md
View File

@ -41,7 +41,7 @@
(define_expand "movmisalign<mode>"
[(set (match_operand:VALL 0 "nonimmediate_operand")
(match_operand:VALL 1 "general_operand"))]
"TARGET_SIMD"
"TARGET_SIMD && !STRICT_ALIGNMENT"
{
/* This pattern is not permitted to fail during expansion: if both arguments
are non-registers (e.g. memory := constant, which can be created by the

5
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2020-02-08 Andrew Pinski <apinski@marvel.com>
PR target/91927
* gcc.target/aarch64/pr91927.c: New testcase.
2020-02-08 Peter Bergner <bergner@linux.ibm.com>
PR target/93136

38
gcc/testsuite/gcc.target/aarch64/pr91927.c Normal file
View File

@ -0,0 +1,38 @@
/* { dg-do compile } */
/* { dg-options "-mstrict-align -O3" } */
#define NULL 0
typedef unsigned uint32_t;
typedef struct __attribute__((__packed__))
{
uint32_t nTagID;
uint32_t nValueBufferSize;
uint32_t nValueLength;
} PropertyTags_t;
typedef struct
{
char *szName;
uint32_t nBufferSize;
uint32_t nLength;
} Something_t;
void SetTag(PropertyTags_t *pTag, uint32_t nBufferSize, uint32_t nLength);
void TestCase(Something_t *pSome, uint32_t nBufferSize, uint32_t nLength)
{
if (pSome != NULL)
{
PropertyTags_t sTag = { 0 };
SetTag(&sTag, nBufferSize, nLength);
pSome->nBufferSize = sTag.nValueBufferSize;
pSome->nLength = sTag.nValueLength;
}
}
/* { dg-final { scan-assembler-not "ldr\td" } } */