OpenE2K
/
gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

re PR rtl-optimization/70222 (Test miscompiled with -O1) 

PR rtl-optimization/70222
	* combine.c (simplify_shift_const_1): For A >> B >> C LSHIFTRT
	optimization if mode is different from result_mode, queue up masking
	of the result in outer_op.  Formatting fix.

	* gcc.c-torture/execute/pr70222-1.c: New test.
	* gcc.c-torture/execute/pr70222-2.c: New test.

From-SVN: r234222
This commit is contained in:
Jakub Jelinek 2016-03-15 17:11:48 +01:00 committed by Jakub Jelinek
parent 511e5c4889
commit c39858bdb8
5 changed files with 73 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gcc/ChangeLog
View File

@ -1,5 +1,10 @@
2016-03-15 Jakub Jelinek <jakub@redhat.com>
PR rtl-optimization/70222
* combine.c (simplify_shift_const_1): For A >> B >> C LSHIFTRT
optimization if mode is different from result_mode, queue up masking
of the result in outer_op. Formatting fix.
PR middle-end/70239
* tree-ssa-sccvn.c (VN_INFO_GET): Use safe_grow_cleared instead
of safe_grow.

14
gcc/combine.c
View File

@ -10524,9 +10524,19 @@ simplify_shift_const_1 (enum rtx_code code, machine_mode result_mode,
&& CONST_INT_P (XEXP (varop, 0))
&& !CONST_INT_P (XEXP (varop, 1)))
{
/* For ((unsigned) (cstULL >> count)) >> cst2 we have to make
sure the result will be masked. See PR70222. */
if (code == LSHIFTRT
&& mode != result_mode
&& !merge_outer_ops (&outer_op, &outer_const, AND,
GET_MODE_MASK (result_mode)
>> orig_count, result_mode,
&complement_p))
break;
rtx new_rtx = simplify_const_binary_operation (code, mode,
XEXP (varop, 0),
GEN_INT (count));
XEXP (varop, 0),
GEN_INT (count));
varop = gen_rtx_fmt_ee (code, mode, new_rtx, XEXP (varop, 1));
count = 0;
continue;

6
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,9 @@
2016-03-15 Jakub Jelinek <jakub@redhat.com>
PR rtl-optimization/70222
* gcc.c-torture/execute/pr70222-1.c: New test.
* gcc.c-torture/execute/pr70222-2.c: New test.
2016-03-15 Richard Henderson <rth@redhat.com>
* gcc.dg/tree-ssa/pr68714.c: Test during reassoc1 pass.

30
gcc/testsuite/gcc.c-torture/execute/pr70222-1.c Normal file
View File

@ -0,0 +1,30 @@
/* PR rtl-optimization/70222 */
int a = 1;
unsigned int b = 2;
int c = 0;
int d = 0;
void
foo ()
{
int e = ((-(c >= c)) < b) > ((int) (-1ULL >> ((a / a) * 15)));
d = -e;
}
__attribute__((noinline, noclone)) void
bar (int x)
{
if (x != -1)
__builtin_abort ();
}
int
main ()
{
#if __CHAR_BIT__ == 8 && __SIZEOF_INT__ == 4 && __SIZEOF_LONG_LONG__ == 8
foo ();
bar (d);
#endif
return 0;
}

20
gcc/testsuite/gcc.c-torture/execute/pr70222-2.c Normal file
View File

@ -0,0 +1,20 @@
/* PR rtl-optimization/70222 */
#if __CHAR_BIT__ == 8 && __SIZEOF_INT__ == 4 && __SIZEOF_LONG_LONG__ == 8
__attribute__((noinline, noclone)) unsigned int
foo (int x)
{
unsigned long long y = -1ULL >> x;
return (unsigned int) y >> 31;
}
#endif
int
main ()
{
#if __CHAR_BIT__ == 8 && __SIZEOF_INT__ == 4 && __SIZEOF_LONG_LONG__ == 8
if (foo (15) != 1 || foo (32) != 1 || foo (33) != 0)
__builtin_abort ();
#endif
return 0;
}