OpenE2K/gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

c-family: fix attribute constructor ICE [PR90658]

Browse Source 
Here the C compiler crashes because a FUNCTION_DECL got into
get_priority -> default_conversion, and the C FE's version of d_c
specifically asserts that it doesn't get a FUNCTION_DECL.  All uses
of default_conversion in c-attribs.cc are guarded by != IDENTIFIER_NODE
&& != FUNCTION_DECL, but get_priority was only checking IDENTIFIER_NODE.

	PR c/90658

gcc/c-family/ChangeLog:

	* c-attribs.cc (get_priority): Check FUNCTION_DECL.

gcc/testsuite/ChangeLog:

	* c-c++-common/attr-cdtor-1.c: New test.
This commit is contained in:
Marek Polacek 2022-05-26 18:59:44 -04:00
parent de57440858
commit ca4b95069c
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gcc/c-family/c-attribs.cc
View File

@ -1895,7 +1895,7 @@ get_priority (tree args, bool is_destructor)
}
arg = TREE_VALUE (args);
if (TREE_CODE (arg) == IDENTIFIER_NODE)
if (TREE_CODE (arg) == IDENTIFIER_NODE || TREE_CODE (arg) == FUNCTION_DECL)
goto invalid;
if (arg == error_mark_node)
return DEFAULT_INIT_PRIORITY;

6
gcc/testsuite/c-c++-common/attr-cdtor-1.c Normal file
View File

@ -0,0 +1,6 @@
/* PR c/90658 */
/* { dg-do compile } */
void f ();
void g1 () __attribute__ ((constructor(f))); /* { dg-error "priorities must be integers" } */
void g2 () __attribute__ ((destructor(f))); /* { dg-error "priorities must be integers" } */