OpenE2K/gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

libstdc++: Enforce copyable/movable checks in std::atomic

Browse Source 
C++20 adds some new preconditions to std::atomic, which weren't
previously checked by our implementation.

	* include/std/atomic (atomic): Add static assertions.
	* testsuite/29_atomics/atomic/requirements/types_neg.cc: New test.
This commit is contained in:
Jonathan Wakely 2020-06-16 22:34:55 +01:00
parent 15cf136abe
commit cc799df98f
2 changed files with 50 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
libstdc++-v3/include/std/atomic
View File

@ -198,6 +198,13 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
static_assert(sizeof(_Tp) > 0,
"Incomplete or zero-sized types are not supported");
#if __cplusplus > 201703L
static_assert(is_copy_constructible_v<_Tp>);
static_assert(is_move_constructible_v<_Tp>);
static_assert(is_copy_assignable_v<_Tp>);
static_assert(is_move_assignable_v<_Tp>);
#endif
public:
atomic() = default;
~atomic() noexcept = default;

43
libstdc++-v3/testsuite/29_atomics/atomic/requirements/types_neg.cc Normal file
View File

@ -0,0 +1,43 @@
// Copyright (C) 2020 Free Software Foundation, Inc.
//
// This file is part of the GNU ISO C++ Library. This library is free
// software; you can redistribute it and/or modify it under the
// terms of the GNU General Public License as published by the
// Free Software Foundation; either version 3, or (at your option)
// any later version.
// This library is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
// You should have received a copy of the GNU General Public License along
// with this library; see the file COPYING3. If not see
// <http://www.gnu.org/licenses/>.
// { dg-options "-std=gnu++2a" }
// { dg-do compile { target c++2a } }
#include <atomic>
std::atomic<const int> a; // { dg-error "here" }
struct MoveOnly
{
MoveOnly() = default;
MoveOnly(MoveOnly&&) = default;
MoveOnly& operator=(MoveOnly&&) = default;
};
std::atomic<MoveOnly> b; // { dg-error "here" }
struct NoMove
{
NoMove() = default;
NoMove(const NoMove&) = default;
NoMove& operator=(const NoMove&) = default;
NoMove(NoMove&&) = delete;
NoMove& operator=(NoMove&&) = delete;
};
std::atomic<NoMove> c; // { dg-error "here" }
// { dg-error "static assertion failed" "" { target *-*-* } 0 }