OpenE2K
/
gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

re PR c++/17816 (duplicate definition of pure virtual function not diagnosed) 

gcc/cp/ChangeLog:
PR c++/17816
* decl.c (redeclaration_error_message): Report redefinition of
pure virtual function.
gcc/testsuite/ChangeLog:
PR c++/17816
* g++.dg/other/redecl2.C: New.

From-SVN: r95008
This commit is contained in:
Alexandre Oliva 2005-02-14 12:01:15 +00:00 committed by Alexandre Oliva
parent af9ecd0ca0
commit d1fc3bbd80
4 changed files with 24 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gcc/cp/ChangeLog
View File

@ -1,3 +1,9 @@
2005-02-14 Alexandre Oliva <aoliva@redhat.com>
PR c++/17816
* decl.c (redeclaration_error_message): Report redefinition of
pure virtual function.
2005-02-11 Nathan Sidwell <nathan@codesourcery.com>
PR c++/19891

3
gcc/cp/decl.c
View File

@ -1913,7 +1913,8 @@ redeclaration_error_message (tree newdecl, tree olddecl)
/* If this is a pure function, its olddecl will actually be
the original initialization to `0' (which we force to call
abort()). Don't complain about redefinition in this case. */
if (DECL_LANG_SPECIFIC (olddecl) && DECL_PURE_VIRTUAL_P (olddecl))
if (DECL_LANG_SPECIFIC (olddecl) && DECL_PURE_VIRTUAL_P (olddecl)
&& DECL_INITIAL (olddecl) == NULL_TREE)
return 0;
/* If both functions come from different namespaces, this is not

5
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2005-02-14 Alexandre Oliva <aoliva@redhat.com>
PR c++/17816
* g++.dg/other/redecl2.C: New.
2005-02-14 Nathan Sidwell <nathan@codesourcery.com>
PR c++/19891

11
gcc/testsuite/g++.dg/other/redecl2.C Normal file
View File

@ -0,0 +1,11 @@
// PR c++/17816
// We failed to report duplicate definitions of pure virtual ns.
// { dg-do compile }
struct S {
virtual int foo() = 0;
};
int S::foo() { return 0; } // { dg-error "defined here" }
int S::foo() { return 0; } // { dg-error "redefinition" }