OpenE2K/gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

compiler: guard against implicit double pointer indirection

Browse Source 
The code that lowers field references can sometimes introduce a double
    pointer indirection in cases where it is not/safe appropriate. For
    example, in
    
            var p **struct { f int }
            p.f = 0
    
    the assignment LHS was being incorrectly lowered to (*(*p)).f.
    Detect this situation and issue an error.
    
    Fixes golang/go#21770
    
    Reviewed-on: https://go-review.googlesource.com/62330

From-SVN: r251918
This commit is contained in:
Ian Lance Taylor 2017-09-09 06:01:35 +00:00
parent 0f99f8e6d6
commit d46699acb0
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gcc/go/gofrontend/MERGE
View File

@ -1,4 +1,4 @@
9d0d5c03a8086f5dd3a23e910abd6e470196973c
52ebad939927e6cbfb48dd277cef8db451e36533
The first line of this file holds the git revision number of the last
merge done from the gofrontend repository.

6
gcc/go/gofrontend/types.cc
View File

@ -11829,6 +11829,12 @@ Type::bind_field_or_method(Gogo* gogo, const Type* type, Expression* expr,
go_assert(st != NULL);
if (type->struct_type() == NULL)
{
if (dereferenced)
{
go_error_at(location, "pointer type has no field %qs",
Gogo::message_name(name).c_str());
return Expression::make_error(location);
}
go_assert(type->points_to() != NULL);
expr = Expression::make_unary(OPERATOR_MULT, expr,
location);