OpenE2K
/
gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

varasm.c (assemble_external): #if 0 out the new assert from the previous commit... 

* varasm.c (assemble_external): #if 0 out the new assert from the 
	previous commit, it breaks the Java and Go front ends.

From-SVN: r185825
This commit is contained in:
Steven Bosscher 2012-03-26 20:23:36 +00:00
parent bbee58432c
commit da3237d15e
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gcc/ChangeLog
View File

@ -1,3 +1,8 @@
2012-03-26 Steven Bosscher <steven@gcc.gnu.org>
* varasm.c (assemble_external): #if 0 out the new assert from the
previous commit, it breaks the Java and Go front ends.
2012-03-26 Steven Bosscher <steven@gcc.gnu.org>
* toplev.c (check_global_declaration_1): Do not call assemble_external.

5
gcc/varasm.c
View File

@ -2170,6 +2170,10 @@ assemble_external (tree decl ATTRIBUTE_UNUSED)
If it's not, we should not be calling this function. */
gcc_assert (asm_out_file);
/* In a perfect world, the following condition would be true.
Sadly, the Java and Go front ends emit assembly *from the front end*,
bypassing the call graph. See PR52739. Fix before GCC 4.8. */
#if 0
/* This function should only be called if we are expanding, or have
expanded, to RTL.
Ideally, only final.c would be calling this function, but it is
@ -2177,6 +2181,7 @@ assemble_external (tree decl ATTRIBUTE_UNUSED)
for further discussion. */
gcc_assert (cgraph_state == CGRAPH_STATE_EXPANSION
|| cgraph_state == CGRAPH_STATE_FINISHED);
#endif
if (!DECL_P (decl) || !DECL_EXTERNAL (decl) || !TREE_PUBLIC (decl))
return;