OpenE2K/gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

backport: re PR c++/92695 (P1064R0 - virtual constexpr fails if object taken from array)

Browse Source 
Backported from mainline
	2019-11-28  Jakub Jelinek  <jakub@redhat.com>

	PR c++/92695
	* decl2.c (mark_used): Don't call note_vague_linkage_fn for pure
	virtual functions, even if they are declared inline.

	* g++.dg/warn/inline3.C: New test.

From-SVN: r279661
This commit is contained in:
Jakub Jelinek 2019-12-20 18:26:28 +01:00 committed by Jakub Jelinek
parent 70d8957fdc
commit e3edafbca9
4 changed files with 36 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gcc/cp/ChangeLog
View File

@ -1,6 +1,12 @@
2019-12-20 Jakub Jelinek <jakub@redhat.com>
Backported from mainline
2019-11-28 Jakub Jelinek <jakub@redhat.com>
PR c++/92695
* decl2.c (mark_used): Don't call note_vague_linkage_fn for pure
virtual functions, even if they are declared inline.
2019-11-27 Jakub Jelinek <jakub@redhat.com>
PR c++/92524

7
gcc/cp/decl2.c
View File

@ -5501,8 +5501,11 @@ mark_used (tree decl, tsubst_flags_t complain)
vec_safe_push (no_linkage_decls, decl);
}
if (TREE_CODE (decl) == FUNCTION_DECL && DECL_DECLARED_INLINE_P (decl)
&& !DECL_INITIAL (decl) && !DECL_ARTIFICIAL (decl))
if (TREE_CODE (decl) == FUNCTION_DECL
&& DECL_DECLARED_INLINE_P (decl)
&& !DECL_INITIAL (decl)
&& !DECL_ARTIFICIAL (decl)
&& !DECL_PURE_VIRTUAL_P (decl))
/* Remember it, so we can check it was defined. */
note_vague_linkage_fn (decl);

5
gcc/testsuite/ChangeLog
View File

@ -1,6 +1,11 @@
2019-12-20 Jakub Jelinek <jakub@redhat.com>
Backported from mainline
2019-11-28 Jakub Jelinek <jakub@redhat.com>
PR c++/92695
* g++.dg/warn/inline3.C: New test.
2019-11-27 Jakub Jelinek <jakub@redhat.com>
PR fortran/91944

20
gcc/testsuite/g++.dg/warn/inline3.C Normal file
View File

@ -0,0 +1,20 @@
struct S {
inline virtual void foo () = 0; // { dg-bogus "used but never defined" }
#if __cplusplus > 201703L
constexpr virtual void bar () = 0; // { dg-bogus "used but never defined" "" { target c++2a } }
#else
inline virtual void bar () = 0; // { dg-bogus "used but never defined" "" { target c++17_down } }
#endif
S () {}
};
struct T : public S {
inline virtual void foo () {}
#if __cplusplus > 201703L
constexpr virtual void bar () {}
#else
inline virtual void bar () {}
#endif
T () {}
};
T t;
void foo (S *s) { s->foo (); s->bar (); }