OpenE2K/gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

re PR tree-optimization/92324 (ICE in expand_direct_optab_fn, at internal-fn.c:2890)

Browse Source 
2019-11-05  Richard Biener  <rguenther@suse.de>

	PR tree-optimization/92324
	* tree-vect-loop.c (check_reduction_path): For MIN/MAX require
	all signed or unsigned operations.

	* gcc.dg/vect/pr92324-3.c: New testcase.

From-SVN: r277822
This commit is contained in:
Richard Biener 2019-11-05 11:00:24 +00:00 committed by Richard Biener
parent a895e6d72d
commit f340142b83
4 changed files with 50 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gcc/ChangeLog
View File

@ -1,3 +1,9 @@
2019-11-05 Richard Biener <rguenther@suse.de>
PR tree-optimization/92324
* tree-vect-loop.c (check_reduction_path): For MIN/MAX require
all signed or unsigned operations.
2019-11-05 Jan Hubicka <jh@suse.cz>
* hsa-brig.c: Include alloc-pool.h

5
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2019-11-05 Richard Biener <rguenther@suse.de>
PR tree-optimization/92324
* gcc.dg/vect/pr92324-3.c: New testcase.
2019-11-05 Jakub Jelinek <jakub@redhat.com>
PR tree-optimization/91945

27
gcc/testsuite/gcc.dg/vect/pr92324-3.c Normal file
View File

@ -0,0 +1,27 @@
#include "tree-vect.h"
int a[1024];
unsigned b[1024];
int __attribute__((noipa))
foo (int n)
{
int res = 0;
for (int i = 0; i < n; ++i)
{
res = res > a[i] ? res : a[i];
res = res > b[i] ? res : b[i];
}
return res;
}
int main ()
{
check_vect ();
b[3] = (unsigned)__INT_MAX__ + 1;
if (foo (4) != -__INT_MAX__ - 1)
__builtin_abort ();
return 0;
}
/* { dg-final { scan-tree-dump-not "vectorized \[1-9\] loops" "vect" } } */

13
gcc/tree-vect-loop.c
View File

@ -2740,6 +2740,7 @@ pop:
/* Check whether the reduction path detected is valid. */
bool fail = path.length () == 0;
bool neg = false;
int sign = -1;
*code = ERROR_MARK;
for (unsigned i = 1; i < path.length (); ++i)
{
@ -2783,12 +2784,22 @@ pop:
TREE_TYPE (gimple_assign_rhs1 (use_stmt))))
;
else if (*code == ERROR_MARK)
*code = use_code;
{
*code = use_code;
sign = TYPE_SIGN (TREE_TYPE (gimple_assign_lhs (use_stmt)));
}
else if (use_code != *code)
{
fail = true;
break;
}
else if ((use_code == MIN_EXPR
|| use_code == MAX_EXPR)
&& sign != TYPE_SIGN (TREE_TYPE (gimple_assign_lhs (use_stmt))))
{
fail = true;
break;
}
}
return ! fail && ! neg && *code != ERROR_MARK;
}